Skip to content

Add retry to Enter-PSHostProcess test #11360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 2 commits into from
Dec 20, 2019
Merged

Add retry to Enter-PSHostProcess test #11360

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d125ca
Add retry to Enter-PSHostProcess test
SteveL-MSFT Dec 16, 2019
1fdcf59
Use -Because to relay trace info
SteveL-MSFT Dec 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion test/powershell/Modules/Microsoft.PowerShell.Core/Enter-PSHostProcess.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,23 @@ Describe "Enter-PSHostProcess tests" -Tag Feature {
$rs.Open()
$ps = [powershell]::Create()
$ps.Runspace = $rs
$ps.AddScript('$pid').Invoke() | Should -Be $pwshId
$ps.AddScript('$pid')

[int]$retry = 0
Copy link
Member

@adityapatwardhan adityapatwardhan Dec 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use Wait-UntilTrue from HelpersCommon.psm1?

Copy link
Member

@adityapatwardhan adityapatwardhan Dec 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not, maybe add a retry function on HelpersCommon.

Copy link
Member Author

@SteveL-MSFT SteveL-MSFT Dec 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worked out a Invoke-ScriptBlockWithRetry function, but it doesn't save much and makes the code harder to understand since I need to pass two types of information back.

$result = $null
$errorMsg = "Exception: "
while ($retry -lt 5 -and $result -eq $null) {
try {
$result = $ps.Invoke()
}
catch [System.Management.Automation.Runspaces.InvalidRunspaceStateException] {
$errorMsg += $_.Exception.InnerException.Message + "; "
$retry++
Start-Sleep -Milliseconds 100
}
}

$result | Should -Be $pwshId -Because $errorMsg
} finally {
$rs.Dispose()
$ps.Dispose()
Expand Down