Skip to content

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Dec 16, 2019

PR Summary

If the user has a UICulture other than en-US, help content is not available and does not successfully update. The user may not know how to get the en-US content. Fix is to update the error informing the user how to choose en-US content.

PR Context

Help content is currently only available as en-US. If the user has a different culture, it does not fallback to en-US which is expected due to geopolitical reasons we cannot assume it is correct to always fallback to en-US automatically.

PR Checklist

@SteveL-MSFT
Copy link
Member Author

@PoshChan please retry windows

@PoshChan
Copy link
Collaborator

@SteveL-MSFT, successfully started retry of PowerShell-CI-Windows

@iSazonov
Copy link
Collaborator

iSazonov commented Dec 16, 2019

due to geopolitical reasons we cannot assume it is correct to always fallback to en-US automatically.

We could add new config/gpo parameter UseHelpFallbackCulture so that users can explicitly say that they want download help files in en-US or another culture.
It is very flexible. If I installed a module without ru-RU localization I could get en-US help files without extra steps.

@SteveL-MSFT
Copy link
Member Author

@iSazonov Let's continue that discussion in the issue #6217

@adityapatwardhan adityapatwardhan merged commit 1f9c3c2 into PowerShell:master Dec 20, 2019
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 21, 2019
@daxian-dbw daxian-dbw modified the milestones: GA-approved, 7.0.0-rc.2 Jan 11, 2020
@ghost
Copy link

ghost commented Jan 16, 2020

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants