-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Added setting to disable implicit WinPS module loading #11332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
requested changes
Dec 12, 2019
daxian-dbw
reviewed
Dec 12, 2019
anmenaga
commented
Dec 13, 2019
joeyaiello
reviewed
Dec 13, 2019
Contributor
joeyaiello
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the one suggestion I added
iSazonov
reviewed
Dec 13, 2019
SteveL-MSFT
reviewed
Dec 20, 2019
src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs
Outdated
Show resolved
Hide resolved
SteveL-MSFT
requested changes
Dec 20, 2019
test/powershell/Modules/Microsoft.PowerShell.Core/CompatiblePSEditions.Module.Tests.ps1
Outdated
Show resolved
Hide resolved
adityapatwardhan
approved these changes
Dec 20, 2019
Member
|
@SteveL-MSFT Please update your review |
SteveL-MSFT
requested changes
Dec 20, 2019
test/powershell/Modules/Microsoft.PowerShell.Core/CompatiblePSEditions.Module.Tests.ps1
Outdated
Show resolved
Hide resolved
SteveL-MSFT
approved these changes
Dec 20, 2019
daxian-dbw
pushed a commit
that referenced
this pull request
Jan 10, 2020
|
🎉 Handy links: |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This adds a Boolean
DisableImplicitWinCompatsetting that can be set inpowershell.config.jsonto disable implicit WinPS module loading.Previously this code was under experimental feature check that was recently removed by
Make approved features non-experimentalPR.This setting does not affect
Import-Module -UseWindowsPowerShellorImport-Module -SkipEditionCheckparameter functionality.Fix #11309
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.