Refactor and implement `Restart-Computer` for `Un*x` and macOS #11319

brendandburns · 2019-12-11T06:00:19Z

PR Summary

Implement the Restart-Computer command for Un*x and MacOS

PR Context

Compliment to the recent implementation of Stop-Computer (#11151)

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
User-facing changes
- Not Applicable
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.

src/Microsoft.PowerShell.Commands.Management/commands/management/ComputerUnix.cs

iSazonov · 2019-12-11T17:25:16Z

@brendandburns Please don't rebase until maintainers ask you. Rebasing complicates reviewing.

src/Microsoft.PowerShell.Commands.Management/commands/management/ComputerUnix.cs

SteveL-MSFT

The Windows Computer cmdlets already use a test hook for testing, should use the same thing here. See https://github.com/PowerShell/PowerShell/blob/master/src/Microsoft.PowerShell.Commands.Management/commands/management/Computer.cs#L2130

iSazonov · 2019-12-11T18:26:46Z

We merged #11151 without new tests.

brendandburns · 2019-12-11T19:00:23Z

I will address comments and add tests for both commands.

Thanks

brendandburns · 2019-12-11T19:07:47Z

@iSazonov is there a preferred style of addressing comments for the PowerShell repo? Should I just add additional commits instead of squashing commits?

(I'm new here :)

Thanks

iSazonov · 2019-12-11T19:31:39Z

Should I just add additional commits instead of squashing commits?

Yes, please add new commits. Some commits or one for all comments.

SteveL-MSFT · 2019-12-11T20:52:15Z

@brendandburns unless there is a need to preserve history, we always squash on merge. For the sake of the reviewers, it's always been easier to add new commits so we can see what exactly changed.

iSazonov · 2019-12-13T06:50:55Z

test/powershell/Modules/Microsoft.PowerShell.Management/Stop-Computer.Tests.ps1

Please remove the commented code.

brendandburns · 2020-01-15T00:59:08Z

@iSazonov @SteveL-MSFT

Sorry it took so long for me to get back to this. I've added tests for both Restart-Computer and Stop-Computer on Unix.

Please take another look.

Thanks!

src/Microsoft.PowerShell.Commands.Management/commands/management/ComputerUnix.cs

iSazonov · 2020-01-15T03:56:10Z

test/powershell/Modules/Microsoft.PowerShell.Management/Restart-Computer.Tests.ps1

Please use It "Should support -computer parameter" -Skip:(!$IsWindows) {

done for all.

iSazonov · 2020-01-15T03:56:27Z

test/powershell/Modules/Microsoft.PowerShell.Management/Restart-Computer.Tests.ps1

The same. Below too.

done for all.

brendandburns · 2020-01-16T05:34:10Z

@iSazonov comments addressed, please re-check.

Thanks!

iSazonov · 2020-01-16T05:57:26Z

@brendandburns Did you address all @SteveL-MSFT 's comments?

brendandburns · 2020-01-16T21:56:21Z

yes, I verified in the code that I had addressed both of the comments from @SteveL-MSFT

Thanks

iSazonov · 2020-01-17T04:10:52Z

@SteveL-MSFT Please update your review.

TravisEz13 · 2020-01-28T23:55:23Z

@SteveL-MSFT Please update your review.

TravisEz13 · 2020-02-03T20:53:56Z

@SteveL-MSFT Please update your review

TravisEz13 · 2020-02-03T21:13:10Z

The merge is bad. I'll fix it.

…nt/ComputerUnix.cs Co-Authored-By: Ilya <darpa@yandex.ru>

TravisEz13 · 2020-02-03T21:54:40Z

Rebased to resolve conflicts and changed #region format to match changes from conflict

TravisEz13 · 2020-02-03T21:55:17Z

@PoshChan Please remind me in 1 hour

PoshChan · 2020-02-03T22:55:33Z

@TravisEz13, this is the reminder you requested 1 hour ago

iSazonov · 2020-02-04T03:28:41Z

@brendandburns Thanks for your contribution!

ghost · 2020-03-26T17:47:21Z

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

brendandburns requested review from adityapatwardhan and daxian-dbw as code owners December 11, 2019 06:00

ghost assigned TravisEz13 Dec 11, 2019

iSazonov reviewed Dec 11, 2019

View reviewed changes

src/Microsoft.PowerShell.Commands.Management/commands/management/ComputerUnix.cs Outdated Show resolved Hide resolved

iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 11, 2019

iSazonov added this to the 7.1.0-preview.1 milestone Dec 11, 2019

brendandburns force-pushed the restarter branch from 8de5006 to b0fb0f3 Compare December 11, 2019 16:26

SteveL-MSFT reviewed Dec 11, 2019

View reviewed changes

src/Microsoft.PowerShell.Commands.Management/commands/management/ComputerUnix.cs Outdated Show resolved Hide resolved

SteveL-MSFT reviewed Dec 11, 2019

View reviewed changes

src/Microsoft.PowerShell.Commands.Management/commands/management/ComputerUnix.cs Outdated Show resolved Hide resolved

SteveL-MSFT requested changes Dec 11, 2019

View reviewed changes

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 11, 2019

ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 11, 2019

iSazonov reviewed Dec 13, 2019

View reviewed changes

brendandburns force-pushed the restarter branch 4 times, most recently from 324fa80 to 65d114c Compare January 15, 2020 00:57

iSazonov reviewed Jan 15, 2020

View reviewed changes

src/Microsoft.PowerShell.Commands.Management/commands/management/ComputerUnix.cs Outdated Show resolved Hide resolved

iSazonov reviewed Jan 15, 2020

View reviewed changes

src/Microsoft.PowerShell.Commands.Management/commands/management/ComputerUnix.cs Outdated Show resolved Hide resolved

iSazonov reviewed Jan 15, 2020

View reviewed changes

SteveL-MSFT approved these changes Feb 3, 2020

View reviewed changes

brendandburns and others added 6 commits February 3, 2020 13:52

Refactor and implement Restart-Computer

c0008da

Add a test for Stop-Computer

cf8087a

Address changes.

9b582ed

Update src/Microsoft.PowerShell.Commands.Management/commands/manageme…

9013ca3

…nt/ComputerUnix.cs Co-Authored-By: Ilya <darpa@yandex.ru>

Update src/Microsoft.PowerShell.Commands.Management/commands/manageme…

011fca0

…nt/ComputerUnix.cs Co-Authored-By: Ilya <darpa@yandex.ru>

Address comments.

3124583

TravisEz13 force-pushed the restarter branch from 33ee635 to 3124583 Compare February 3, 2020 21:53

TravisEz13 changed the title ~~Refactor and implement Restart-Computer for Un*x and MacOS~~ Refactor and implement Restart-Computer for Un*x and macOS Feb 3, 2020

TravisEz13 merged commit 127fec5 into PowerShell:master Feb 3, 2020

sdwheeler mentioned this pull request May 20, 2020

Add Restart-Computer for Un*x and macOS MicrosoftDocs/PowerShell-Docs#5979

Closed

12 tasks

Refactor and implement Restart-Computer for Un*x and macOS #11319

Refactor and implement Restart-Computer for Un*x and macOS #11319

Uh oh!

Conversation

brendandburns commented Dec 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

Uh oh!

iSazonov commented Dec 11, 2019

Uh oh!

Uh oh!

Uh oh!

SteveL-MSFT left a comment

Choose a reason for hiding this comment

Uh oh!

iSazonov commented Dec 11, 2019

Uh oh!

brendandburns commented Dec 11, 2019

Uh oh!

brendandburns commented Dec 11, 2019

Uh oh!

iSazonov commented Dec 11, 2019

Uh oh!

SteveL-MSFT commented Dec 11, 2019

Uh oh!

iSazonov Dec 13, 2019

Choose a reason for hiding this comment

Uh oh!

brendandburns Jan 15, 2020

Choose a reason for hiding this comment

Uh oh!

brendandburns commented Jan 15, 2020

Uh oh!

Uh oh!

Uh oh!

iSazonov Jan 15, 2020

Choose a reason for hiding this comment

Uh oh!

brendandburns Jan 16, 2020

Choose a reason for hiding this comment

Uh oh!

iSazonov Jan 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brendandburns Jan 16, 2020

Choose a reason for hiding this comment

Uh oh!

brendandburns commented Jan 16, 2020

Uh oh!

iSazonov commented Jan 16, 2020

Uh oh!

brendandburns commented Jan 16, 2020

Uh oh!

iSazonov commented Jan 17, 2020

Uh oh!

TravisEz13 commented Jan 28, 2020

Uh oh!

TravisEz13 commented Feb 3, 2020

Uh oh!

TravisEz13 commented Feb 3, 2020

Uh oh!

TravisEz13 commented Feb 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TravisEz13 commented Feb 3, 2020

Uh oh!

PoshChan commented Feb 3, 2020

Uh oh!

iSazonov commented Feb 4, 2020

Uh oh!

ghost commented Mar 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Refactor and implement `Restart-Computer` for `Un*x` and macOS #11319

Refactor and implement `Restart-Computer` for `Un*x` and macOS #11319

brendandburns commented Dec 11, 2019 •

edited

Loading

iSazonov Jan 15, 2020 •

edited

Loading

TravisEz13 commented Feb 3, 2020 •

edited

Loading