Fix Nuget package signing for Coordinated Package build #11316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulHigin
requested review from
TravisEz13,
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
ghost
assigned
daxian-dbw
approved these changes
Dec 10, 2019
| outPathRoot: '$(System.ArtifactsDirectory)\signed' | ||
| binVersion: $(SigingVersion) | ||
| binVersionOverride: $(SigningVersionOverride) | ||
| condition: and(succeeded(), eq(variables['SHOULD_SIGN'], 'true')) |
Member
There was a problem hiding this comment.
Just curious, where is this variable defined?
Member
There was a problem hiding this comment.
It get defined by calling the template in line 60
adityapatwardhan
added
the
CL-BuildPackaging
adityapatwardhan
approved these changes
Dec 10, 2019
Member
|
Merged this before waiting for 24 hours, as this blocks nightly build. |
|
🎉 Handy links: |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR fixes Coordinated Packages build failure by updating nuget build yml to perform signing for scheduled builds via SHOULD_SIGN variable.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.