Skip to content

Conversation

@JamesWTruher
Copy link
Collaborator

If the date setting throws, set the default to UnixEpoch

PR Summary

On Raspbian sometimes the date can't be constructed, so in that case just set the date to UnixEpoch

PR Checklist

@adityapatwardhan adityapatwardhan added this to the rc.1-consider milestone Dec 10, 2019
@daxian-dbw
Copy link
Member

@JamesWTruher Can you please take a look at the CI failures?

Copy link
Collaborator

@iSazonov iSazonov Dec 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add more information why this happens and under what conditions?
It would useful because we have not tests for the scenario.

If the date setting throws, set the default to UnixEpoch
@adityapatwardhan
Copy link
Member

@daxian-dbw Ready to merge?

@daxian-dbw daxian-dbw merged commit bcc5acb into PowerShell:master Dec 12, 2019
adityapatwardhan pushed a commit that referenced this pull request Dec 13, 2019
@daxian-dbw daxian-dbw added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 14, 2019
@ghost
Copy link

ghost commented Dec 16, 2019

🎉v7.0.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants