-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Improvements in breakpoint APIs for remote scenarios #11312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements in breakpoint APIs for remote scenarios #11312
Conversation
|
The "hook in output" commit hooks up the ability to send output to the original client PowerShell without needing to invoke a pipeline on the server side. |
src/System.Management.Automation/engine/remoting/server/ServerRunspacePoolDriver.cs
Outdated
Show resolved
Hide resolved
|
@PoshChan please retry PowerShell-CI-static-analysis |
|
@TylerLeonhardt, I do not understand the build target(s) |
|
@PoshChan please retry static |
|
@TylerLeonhardt, successfully started retry of |
|
@PoshChan please retry static |
|
@PoshChan please retry windows |
src/System.Management.Automation/engine/remoting/server/ServerRunspacePoolDriver.cs
Show resolved
Hide resolved
src/System.Management.Automation/resources/DebuggerStrings.resx
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/remoting/server/ServerRunspacePoolDriver.cs
Show resolved
Hide resolved
PaulHigin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@SteveL-MSFT - please update your review |
src/System.Management.Automation/engine/remoting/client/remoterunspace.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/remoting/client/remoterunspace.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/remoting/server/ServerRunspacePoolDriver.cs
Show resolved
Hide resolved
|
@SteveL-MSFT - please re-review |
|
🎉 Handy links: |
PR Summary
This addresses two things:
This is only added to the API surface for the PowerShell extension. In theory the breakpoint cmdlets can take advantage of this in the future.
PR Context
This will light up a scenario in the PowerShell Editor Services so that when you click to add a breakpoint, that breakpoint will be applied even if the PowerShell Integrated Console is busy running the
Debug-Runspace.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.