Skip to content

Change comment and element text to meet MS standards #11304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 1 commit into from
Dec 10, 2019
Merged

Change comment and element text to meet MS standards #11304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.PowerShell.Commands.Utility/commands/utility/ImplicitRemotingCommands.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1199,7 +1199,7 @@ private bool IsSafeCommandMetadata(CommandMetadata commandMetadata)
Dbg.Assert(parameter.Attributes == null || parameter.Attributes.Count == 0,
"Attributes shouldn't get rehydrated");

// sanitize - remove type constraint that are not whitelisted
// sanitize - remove type constraint that are not allowed
if (!IsSafeTypeConstraint(parameter.ParameterType))
{
parameter.ParameterType = null;
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ private object ReadLineSafe(bool isSecureString, char? printToken)
#if UNIX
else if (char.IsControl(keyInfo.KeyChar))
{
// blacklist control characters
// deny list control characters
continue;
}
#endif
Expand Down Expand Up @@ -1785,7 +1785,7 @@ private string ReadLineFromConsole(bool endOnTab, string initialContent, bool ca

if (char.IsControl(keyInfo.KeyChar))
{
// blacklist control characters
// deny list control characters
continue;
}

Expand Down
4 changes: 2 additions & 2 deletions src/System.Management.Automation/CoreCLR/CorePsAssemblyLoadContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ private PowerShellAssemblyLoadContext(string basePaths)
// - Value: strong name of the TPA that contains the type represented by Key.
private readonly Dictionary<string, string> _coreClrTypeCatalog;
private readonly Lazy<HashSet<string>> _availableDotNetAssemblyNames;
private readonly HashSet<string> _blackListedAssemblies = new HashSet<string>(StringComparer.OrdinalIgnoreCase){
private readonly HashSet<string> _denyListedAssemblies = new HashSet<string>(StringComparer.OrdinalIgnoreCase){
"System.Windows.Forms"
};

Expand Down Expand Up @@ -331,7 +331,7 @@ private Assembly Resolve(AssemblyLoadContext loadContext, AssemblyName assemblyN
private bool TryFindInGAC(AssemblyName assemblyName, out string assemblyFilePath)
{
assemblyFilePath = null;
if (_blackListedAssemblies.Contains(assemblyName.Name))
if (_denyListedAssemblies.Contains(assemblyName.Name))
{
// DotNet catches and throws a new exception with no inner exception
// We cannot change the message DotNet returns.
Expand Down