Skip to content

Add null host name check in WSMan #11288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anmenaga merged 3 commits into from
Dec 9, 2019
Merged

Add null host name check in WSMan #11288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7a03ca
Convert DateTime to string
iSazonov Nov 28, 2019
5ae4e95
Add null host name check in wsman
iSazonov Dec 7, 2019
b0ab2fa
Revert "Convert DateTime to string"
iSazonov Dec 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Microsoft.WSMan.Management/ConfigProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1446,6 +1446,11 @@ protected override bool IsItemContainer(string path)

// Get the wsman host name to find the session object
string host = GetHostName(path);
if (string.IsNullOrEmpty(host))
{
return false;
}

string WsManURI = NormalizePath(path, host);

lock (WSManHelper.AutoSession)
Expand Down
4 changes: 4 additions & 0 deletions test/powershell/Modules/Microsoft.WSMan.Management/ConfigProvider.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@ Describe "WSMan Config Provider" -Tag Feature,RequireAdminOnWindows {
}
}
}

It "Container check works" {
Test-Path wsman:\foo -PathType container | Should -BeFalse
}
}

Context "Get-Item tests" {
Expand Down