-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix NullReferenceException in CompletionCompleters public methods #11274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@daxian-dbw nice work! Any chance this might make it in for 7.0 GA timeframe? It doesn't feel right to be shipping a major version with an NRE from a public API. 😄 |
|
It seems the public API was never used because it did not work :-) |
|
@vexx32 I feel the same :) Changed the milestone to |
|
@TravisEz13 @PaulHigin Please look the change in public API. |
|
This also fails on WinPS5.1 so it's not a regression. It's not clear to me outside of calling the API the user experience that is broken. |
|
🎉 Handy links: |
PR Summary
Fix #11227,
NullReferenceExceptioninCompletionCompleterspublic methods:PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.