Skip to content

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Dec 5, 2019

PR Summary

Fix #11227, NullReferenceException in CompletionCompleters public methods:

[CompletionCompleters]::CompleteType(string typeName)
[CompletionCompleters]::CompleteVariable(string variableName)

PR Context

PR Checklist

@ghost ghost assigned iSazonov Dec 5, 2019
@daxian-dbw daxian-dbw added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Dec 6, 2019
@daxian-dbw daxian-dbw added this to the 7.1.0-preview.1 milestone Dec 6, 2019
@vexx32
Copy link
Collaborator

vexx32 commented Dec 6, 2019

@daxian-dbw nice work! Any chance this might make it in for 7.0 GA timeframe? It doesn't feel right to be shipping a major version with an NRE from a public API. 😄

@iSazonov
Copy link
Collaborator

iSazonov commented Dec 6, 2019

It seems the public API was never used because it did not work :-)

@daxian-dbw
Copy link
Member Author

@vexx32 I feel the same :) Changed the milestone to rc1-consider and wait for triage.

@iSazonov
Copy link
Collaborator

iSazonov commented Dec 9, 2019

@TravisEz13 @PaulHigin Please look the change in public API.

@SteveL-MSFT
Copy link
Member

This also fails on WinPS5.1 so it's not a regression. It's not clear to me outside of calling the API the user experience that is broken.

@iSazonov iSazonov merged commit 25895e3 into PowerShell:master Dec 10, 2019
@TravisEz13 TravisEz13 modified the milestones: rc.1-approved, 7.0.0-rc.1 Dec 11, 2019
@daxian-dbw daxian-dbw deleted the nullex branch December 12, 2019 00:10
@ghost
Copy link

ghost commented Dec 16, 2019

🎉v7.0.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[System.Management.Automation.CompletionCompleters]::CompleteVariable throw ArgumentNullException

6 participants