Fix a regression in formatting caused by the 'FirstOrDefault' primitive added in 7.0.0-Preview1 #11258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxian-dbw
changed the title
daxian-dbw
added
the
CL-Engine
iSazonov
approved these changes
Dec 4, 2019
Collaborator
iSazonov
left a comment
iSazonov
left a comment
There was a problem hiding this comment.
LGTM with one minor comment.
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # Licensed under the MIT License. | ||
|
|
||
| Describe 'Bug fixes related to formatting' -Tag CI { |
Collaborator
There was a problem hiding this comment.
I think it is better to have positive and functional names for the file and describe.
Member
Author
There was a problem hiding this comment.
Updated the test name, but kept the file name unchanged. I would like this file to be used for future bug fixes related to formatting.
rjmholt
reviewed
Dec 4, 2019
rjmholt
approved these changes
Dec 5, 2019
adityapatwardhan
approved these changes
Dec 11, 2019
adityapatwardhan
pushed a commit
that referenced
this pull request
Dec 13, 2019
…ve added in `7.0.0-Preview1` (#11258)
|
🎉 Handy links: |
ghost
mentioned this pull request
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #10554
Hidden members should not be returned by any fuzzy searches, such as searching by 'match' or enumerating the collection. They are returned only if the member names are explicitly looked for.
FirstOrDefaultis a fuzzy search, so it should ignore the hidden members.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.