Skip to content

Convert DateTime to string in setReleaseTag #11209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iSazonov wants to merge 1 commit into from
Closed

Convert DateTime to string in setReleaseTag #11209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tools/releaseBuild/setReleaseTag.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ function New-BuildInfoJson {
## Get the UTC time and round up to the second.
$dateTime = [datetime]::UtcNow
$dateTime = [datetime]::new($dateTime.Ticks - ($dateTime.Ticks % [timespan]::TicksPerSecond), $dateTime.Kind)
$dateTime = $dateTime.ToString("o")
Copy link
Member

@daxian-dbw daxian-dbw Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose is to get the precision up to second, like 2019-12-03T22:04:15Z. ToString("o") gives you 2019-12-03T22:04:15.0000000Z.

We don't need to address this now, as the preview.json, stable.json and lts.json will have the ReleaseDate re-set at the end of the release pipeline, where pwsh is used.
I think we need to make the build agent pre-install pwsh eventually.


@{
ReleaseTag = $ReleaseTag
Expand Down