-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Update formatter to not write newlines if content is empty #11193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PoshChan
reviewed
Nov 25, 2019
src/System.Management.Automation/FormatAndOutput/common/ComplexWriter.cs
Show resolved
Hide resolved
PoshChan
reviewed
Nov 25, 2019
src/System.Management.Automation/FormatAndOutput/common/ComplexWriter.cs
Show resolved
Hide resolved
PoshChan
reviewed
Nov 25, 2019
src/System.Management.Automation/FormatAndOutput/common/ComplexWriter.cs
Show resolved
Hide resolved
Member
Author
|
This turned out to be a bit more complex than I thought. An empty string represents a newline. |
PoshChan
reviewed
Nov 26, 2019
src/System.Management.Automation/FormatAndOutput/common/ComplexWriter.cs
Show resolved
Hide resolved
PoshChan
reviewed
Nov 26, 2019
src/System.Management.Automation/FormatAndOutput/common/ComplexWriter.cs
Show resolved
Hide resolved
PoshChan
reviewed
Nov 26, 2019
src/System.Management.Automation/FormatAndOutput/common/ComplexWriter.cs
Show resolved
Hide resolved
iSazonov
reviewed
Nov 26, 2019
test/powershell/Modules/Microsoft.PowerShell.Utility/Format-Custom.Tests.ps1
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/FormatAndOutput/common/FormatViewGenerator_Complex.cs
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Format-Custom.Tests.ps1
Outdated
Show resolved
Hide resolved
…stom.Tests.ps1 Co-Authored-By: Ilya <darpa@yandex.ru>
…ViewGenerator_Complex.cs Co-Authored-By: Ilya <darpa@yandex.ru>
…stom.Tests.ps1 Co-Authored-By: Ilya <darpa@yandex.ru>
iSazonov
approved these changes
Nov 27, 2019
iSazonov
added a commit
to iSazonov/PowerShell
that referenced
this pull request
Dec 14, 2019
…owerShell#11193)" This reverts commit 51d2523.
14 tasks
iSazonov
added a commit
that referenced
this pull request
Dec 17, 2019
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Currently, the formatter uses
WriteLine()on the content expecting it to be not empty. If the custom format explicitly doesn't write anything, it ends up as a newline. Fix is to check that there is something to write, otherwise bail out early. With this change, an empty string still results in a newline, but$nullskips writing the newline.PR Context
Affects a custom formatter I'm writing that requires output to not have trailing newlines.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.