Skip to content

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Nov 22, 2019

PR Summary

Update macOS minimum version

PR Context

DotNet Core 3.1 doesn't support 10.13 anymore.

PR Checklist

@TravisEz13 TravisEz13 changed the title Update macos minimum version Update macOS minimum version Nov 22, 2019
@TravisEz13 TravisEz13 added this to the rc.1-consider milestone Nov 22, 2019
@SteveL-MSFT
Copy link
Member

Should you also update docs\building\macos.md?

@TravisEz13
Copy link
Member Author

Done.

@TravisEz13 TravisEz13 added the AutoMerge informs the bot to automerge the PR label Nov 22, 2019
@ghost
Copy link

ghost commented Nov 22, 2019

Hello @TravisEz13!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 24 hours, a condition that will be fulfilled in about 21 hours 52 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 22, 2019
@TravisEz13
Copy link
Member Author

ping

@ghost ghost assigned iSazonov Nov 23, 2019
@TravisEz13
Copy link
Member Author

@iSazonov The bot will now round robin assign between the maintainers. consider the initial task to triage and feel free to assign to another maintainer.

@iSazonov iSazonov merged commit b60381f into PowerShell:master Nov 24, 2019
TravisEz13 added a commit that referenced this pull request Dec 4, 2019
@TravisEz13 TravisEz13 modified the milestones: rc.1-approved, 7.0.0-rc.1 Dec 4, 2019
@TravisEz13 TravisEz13 deleted the update_macos_minimun branch December 4, 2019 23:47
@ghost
Copy link

ghost commented Dec 16, 2019

🎉v7.0.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMerge informs the bot to automerge the PR CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants