Improve Ubuntu detection for Ubuntu derivatives like GalliumOS etc. #11155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendandburns
requested review from
TravisEz13,
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
TravisEz13
reviewed
Nov 22, 2019
ghost
added
the
Waiting on Author
brendandburns
force-pushed
the
better
branch
from
23e82bc to
85580b7
Compare
ghost
removed
the
Waiting on Author
Contributor
Author
|
Comment addressed. Please re-check. |
Contributor
Author
|
fwiw, the CodeFactor failures don't appear to be related to this change. Do I need to rebase? |
SteveL-MSFT
approved these changes
Nov 26, 2019
Member
|
@brendanburns CodeFactor isn't a merge blocker. Since you looked at the failures and they are not related to your change, you can ignore. Looks good, thanks for your contribution! |
TravisEz13
approved these changes
Nov 26, 2019
daxian-dbw
added
the
CL-BuildPackaging
daxian-dbw
pushed a commit
that referenced
this pull request
Jan 10, 2020
|
🎉 Handy links: |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Improve detection of Ubuntu-based systems
PR Context
There are lots of Ubuntu deriviatives out there, but they all are based on Ubuntu and thus supported by this script. Improve detection of such distros using the
lsb_releasetool.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.