-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Make update notification support LTS and default channels #11132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Microsoft.PowerShell.ConsoleHost/host/msh/UpdatesNotification.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.ConsoleHost/host/msh/UpdatesNotification.cs
Outdated
Show resolved
Hide resolved
|
@PoshChan please retry windows |
|
@daxian-dbw, successfully started retry of |
src/Microsoft.PowerShell.ConsoleHost/host/msh/UpdatesNotification.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.ConsoleHost/host/msh/UpdatesNotification.cs
Outdated
Show resolved
Hide resolved
|
@PoshChan please retry windows |
|
@daxian-dbw, successfully started retry of |
|
@PoshChan please retry windows |
|
@daxian-dbw, successfully started retry of |
|
@adityapatwardhan I think this PR is ready to be merged. |
|
🎉 Handy links: |
PR Summary
Update the feature to support the notification type that can be configured using the environment variable
POWERSHELL_UPDATECHECK.This is to address the feedback from powershell committee in the RFC review: PowerShell/PowerShell-RFC#162 (comment), quoted below:
POWERSHELL_UPDATECHECKaccepts 3 values:Off,Default, andLTS(case-insensitive), and the behavior is as follows:Off: turn off the udpate notification.Default: give you the default behaviorsLTS: both preview and GA version 'pwsh' checks for the new LTS version only.For a specific version of pwsh and a specific notification type, only one update check task, at most, will run to complete per a day. Other tasks should be able to detect "a check is in progress" or "the check has been done for today" and bail out early, to avoid any unnecessary network IO or CPU cycles.
Note that this is a breaking change comparing to
preview-5andpreview-6, because the environment variable name and its accepted values are changed.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.