Skip to content

Conversation

@TravisEz13
Copy link
Member

PR Summary

Make unreliable DSC test pending

PR Context

In release automation, this test cannot find the module

PR Checklist

}

it "Resource with embedded resource not supported and a warning should be produced" {
it "Resource with embedded resource not supported and a warning should be produced" -Pending {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Set-ItResult instead

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 22, 2019
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 22, 2019
@adityapatwardhan adityapatwardhan added the AutoMerge informs the bot to automerge the PR label Nov 22, 2019
@ghost
Copy link

ghost commented Nov 22, 2019

Hello @adityapatwardhan!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@adityapatwardhan adityapatwardhan added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Nov 22, 2019
@adityapatwardhan adityapatwardhan self-assigned this Nov 22, 2019
@TravisEz13 TravisEz13 added this to the rc.1-consider milestone Nov 22, 2019
@TravisEz13 TravisEz13 merged commit 72780f3 into master Nov 22, 2019
@TravisEz13 TravisEz13 deleted the TravisEz13-patch-1 branch November 22, 2019 22:18
TravisEz13 added a commit that referenced this pull request Dec 4, 2019
@TravisEz13 TravisEz13 modified the milestones: rc.1-approved, 7.0.0-rc.1 Dec 4, 2019
@ghost
Copy link

ghost commented Dec 16, 2019

🎉v7.0.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMerge informs the bot to automerge the PR CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants