Update Get-Error to not modify the original $Error object #11125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CodeFactor issue is by-design |
vexx32
reviewed
Nov 20, 2019
Collaborator
vexx32
left a comment
vexx32
left a comment
There was a problem hiding this comment.
Looks good! Minor non-blocking comments only.
Nicely done! 😊
src/Microsoft.PowerShell.Commands.Utility/commands/utility/Get-Error.cs
Outdated
Show resolved
Hide resolved
Comment on lines
+113
to
+117
| try { | ||
| 1 / 0 | ||
| } | ||
| catch { | ||
| } |
Collaborator
There was a problem hiding this comment.
I know it doesn't really matter, but is there a reason you didn't just use Write-Error for this purpose? 😄
Member
Author
There was a problem hiding this comment.
Didn't consider that and this was the first thing I thought of. At least now it's consistent within the test script :)
Although I also learned later that you can just write to $Error anyways.
iSazonov
added
the
CL-General
iSazonov
approved these changes
Nov 20, 2019
…-Error.cs Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
vexx32
approved these changes
Nov 20, 2019
|
🎉 Handy links: |
ghost
mentioned this pull request
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Get-Errorcurrently modifies the original $Error object specifically the pstypenames. Fix is to use an overload when constructing the PSObject to copy it.PR Context
Fix #11122
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.