-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix null reference in SupportsVirtualTerminal property #11105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
iSazonov
merged 3 commits into
PowerShell:master
from
PaulHigin:fix-supportsvirtualterminal-nullref
Nov 19, 2019
Merged
Fix null reference in SupportsVirtualTerminal property #11105
iSazonov
merged 3 commits into
PowerShell:master
from
PaulHigin:fix-supportsvirtualterminal-nullref
Nov 19, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
approved these changes
Nov 18, 2019
PoshChan
reviewed
Nov 18, 2019
src/System.Management.Automation/engine/hostifaces/InternalHostUserInterface.cs
Show resolved
Hide resolved
PoshChan
reviewed
Nov 18, 2019
src/System.Management.Automation/engine/hostifaces/InternalHostUserInterface.cs
Show resolved
Hide resolved
SteveL-MSFT
approved these changes
Nov 18, 2019
Collaborator
|
@SteveL-MSFT Why do msbot not grab the PR for Preview6? Also I did not find the PR in CHANGELOG and on release page. |
|
🎉 Handy links: |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixed a null reference exception being thrown by InternalHostUserInterface.SupportsVirtualTerminal.
Fix #11052
PR Context
The _externalUI field of the InternalHostUserInterface class can be null (e.g., PowerShell's DefaultHost implementation),
and so must be checked before being referenced.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.