Skip to content

Conversation

@PaulHigin
Copy link
Contributor

@PaulHigin PaulHigin commented Nov 18, 2019

PR Summary

Fixed a null reference exception being thrown by InternalHostUserInterface.SupportsVirtualTerminal.
Fix #11052

PR Context

The _externalUI field of the InternalHostUserInterface class can be null (e.g., PowerShell's DefaultHost implementation),

// externalUI may be null
_externalUI = externalUI;

and so must be checked before being referenced.

PR Checklist

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 18, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.6 milestone Nov 18, 2019
@iSazonov iSazonov merged commit 48f95f0 into PowerShell:master Nov 19, 2019
@PaulHigin PaulHigin deleted the fix-supportsvirtualterminal-nullref branch November 19, 2019 15:28
@iSazonov
Copy link
Collaborator

@SteveL-MSFT Why do msbot not grab the PR for Preview6? Also I did not find the PR in CHANGELOG and on release page.

@ghost
Copy link

ghost commented Dec 16, 2019

🎉v7.0.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Powershell 7 Preview 5 | Select-String -Pattern crashes when executed in ForEach-Object -Parallel

5 participants