Skip to content

Add Type member to Exceptions containing type of exception for Get-Error #11076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 4 commits into from
Nov 22, 2019
Merged

Add Type member to Exceptions containing type of exception for Get-Error #11076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dbd4b00
Add `ExceptionType` member to Exceptions for `Get-Error`
SteveL-MSFT Nov 14, 2019
871675a
fix test for Windows
SteveL-MSFT Nov 15, 2019
4401010
change `ExceptionType` to just `Type`
SteveL-MSFT Nov 19, 2019
770f063
fix test
SteveL-MSFT Nov 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...m.Management.Automation/FormatAndOutput/DefaultFormatters/PowerShellCore_format_ps1xml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,6 +771,11 @@ private static IEnumerable<FormatViewDefinition> ViewsOf_System_Management_Autom
'System.Management.Automation.InvocationInfo'
)

# if object is an Exception, add an ExceptionType property
if ($obj -is [Exception]) {
$obj | Add-Member -NotePropertyName Type -NotePropertyValue $obj.GetType().FullName -ErrorAction Ignore
}

# first find the longest property so we can indent properly
$propLength = 0
foreach ($prop in $obj.PSObject.Properties) {
Expand Down
20 changes: 20 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Error.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,4 +90,24 @@ Describe 'Get-Error tests' -Tag CI {
$out | Should -BeLikeExactly '*ExpectedValueExpression*'
$out | Should -BeLikeExactly '*UnexpectedToken*'
}

It 'Get-Error adds ExceptionType for Exceptions' {
try {
[System.Net.DNS]::GetHostByName((New-Guid))
}
catch {
}

$out = Get-Error | Out-String
$out | Should -BeLikeExactly '*Type*'

if ($IsWindows) {
$expectedExceptionType = "System.Management.Automation.ParentContainsErrorRecordException"
}
else {
$expectedExceptionType = "System.Net.Internals.SocketExceptionFactory+ExtendedSocketException"
}

$out | Should -BeLikeExactly "*$expectedExceptionType*"
}
}