Skip to content

Add Type member to Exceptions containing type of exception for Get-Error #11076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 4 commits into from
Nov 22, 2019
Merged

Add Type member to Exceptions containing type of exception for Get-Error #11076

TravisEz13 merged 4 commits into from
Nov 22, 2019

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Nov 14, 2019 •
edited
Loading

PR Summary

For Get-Error cmdlet, if the object (or nested object) is an Exception, we add an ExceptionType property that has the full type name. The Exception type is useful information and this change doesn't require the user to explore the error object to get it.

Example:

PS> 1/0
RuntimeException: Attempted to divide by zero.
PS> gerr

Exception             :
    ExceptionType  : System.Management.Automation.RuntimeException
    ErrorRecord    :
        Exception             :
            ExceptionType : System.Management.Automation.ParentContainsErrorRecordException
            Message       : Attempted to divide by zero.
            HResult       : -2146233087
        CategoryInfo          : NotSpecified: (:) [], ParentContainsErrorRecordException
        FullyQualifiedErrorId : RuntimeException
        InvocationInfo        :
            ScriptLineNumber : 1
            OffsetInLine     : 1
            HistoryId        : -1
            Line             : 1/0
            PositionMessage  : At line:1 char:1
                               + 1/0
                               + ~~~
            CommandOrigin    : Internal
        ScriptStackTrace      : at <ScriptBlock>, <No file>: line 1
    TargetSite     :
        Name          : Divide
        DeclaringType : System.Management.Automation.IntOps
        MemberType    : Method
        Module        : System.Management.Automation.dll
    StackTrace     :
   at System.Management.Automation.IntOps.Divide(Int32 lhs, Int32 rhs) in /Users/steve/repos/PowerShell/src/System.Management.Automation/engine/runtime/Operations/NumericOps.cs:line 61
   at System.Dynamic.UpdateDelegates.UpdateAndExecute2[T0,T1,TRet](CallSite site, T0 arg0, T1 arg1)
   at System.Management.Automation.Interpreter.DynamicInstruction`3.Run(InterpretedFrame frame) in /Users/steve/repos/PowerShell/src/System.Management.Automation/engine/interpreter/DynamicInstructions.Generated.cs:line 166
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame) in /Users/steve/repos/PowerShell/src/System.Management.Automation/engine/interpreter/ControlFlowInstructions.cs:line 357
    Message        : Attempted to divide by zero.
    Data           : System.Collections.ListDictionaryInternal
    InnerException :
        ExceptionType : System.DivideByZeroException
        Message       : Attempted to divide by zero.
        HResult       : -2147352558
    Source         : System.Management.Automation
    HResult        : -2146233087
CategoryInfo          : NotSpecified: (:) [], RuntimeException
FullyQualifiedErrorId : RuntimeException
InvocationInfo        :
    ScriptLineNumber : 1
    OffsetInLine     : 1
    HistoryId        : -1
    Line             : 1/0
    PositionMessage  : At line:1 char:1
                       + 1/0
                       + ~~~
    CommandOrigin    : Internal
ScriptStackTrace      : at <ScriptBlock>, <No file>: line 1

PR Checklist

@TravisEz13
Copy link
Member

TravisEz13 commented Nov 14, 2019

@PoshChan Please remind me in 1 hour

@PoshChan
Copy link
Collaborator

PoshChan commented Nov 14, 2019

@TravisEz13, this is the reminder you requested 1 hour ago

@TravisEz13
Copy link
Member

TravisEz13 commented Nov 15, 2019

@PoshChan Please remind me in 1 hour

@PoshChan
Copy link
Collaborator

PoshChan commented Nov 15, 2019

@TravisEz13, this is the reminder you requested 1 hour ago

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 16, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.6 milestone Nov 16, 2019
@SteveL-MSFT SteveL-MSFT mentioned this pull request Nov 19, 2019
Closed
@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Nov 19, 2019

changed property name from ExceptionType to just Type based on @mklement0's feedback

@mklement0 mklement0 mentioned this pull request Nov 19, 2019
Closed
@SteveL-MSFT SteveL-MSFT changed the title Add ExceptionType member to Exceptions for Get-Error Add Type member to Exceptions containing type of exception for Get-Error Nov 19, 2019
@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Nov 19, 2019

@PoshChan please retry windows

@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Nov 19, 2019

CodeFactor issue is by-design

@PoshChan
Copy link
Collaborator

PoshChan commented Nov 19, 2019

@SteveL-MSFT, successfully started retry of PowerShell-CI-Windows

@mklement0 mklement0 mentioned this pull request Nov 19, 2019
Closed
@TravisEz13 TravisEz13 merged commit 2f67253 into PowerShell:master Nov 22, 2019
@SteveL-MSFT SteveL-MSFT removed this from the 7.0.0-rc.1 milestone Dec 4, 2019
@SteveL-MSFT SteveL-MSFT deleted the get-error-exception-type branch December 4, 2019 22:42
@TravisEz13 TravisEz13 modified the milestones: rc.1-approved, 7.0.0-rc.1 Dec 4, 2019
@TravisEz13 TravisEz13 modified the milestones: 7.0.0-rc.1, GA-approved Dec 20, 2019
daxian-dbw pushed a commit that referenced this pull request Jan 10, 2020
@SteveL-MSFT @daxian-dbw
Add Type member to Exceptions containing type of exception for `Get…
c5bc120 
…-Error` (#11076)
@daxian-dbw daxian-dbw modified the milestones: GA-approved, 7.0.0-rc.2 Jan 11, 2020
@ghost
Copy link

ghost commented Jan 16, 2020

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 left review comments

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@iSazonov iSazonov iSazonov approved these changes

@JamesWTruher JamesWTruher Awaiting requested review from JamesWTruher

+1 more reviewer

@PoshChan PoshChan PoshChan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.0.0-rc.2

Development

Successfully merging this pull request may close these issues.

6 participants

@SteveL-MSFT @TravisEz13 @PoshChan @adityapatwardhan @iSazonov @daxian-dbw