Skip to content

Fix Start-Job working directory path with trailing back slash - #11041

Merged
Aditya Patwardhan (adityapatwardhan) merged 4 commits into
PowerShell:masterfrom
PaulHigin:fix-startjob-wd-withtrailingbackslash
Nov 16, 2019
Merged

Aditya Patwardhan (adityapatwardhan) merged 4 commits into
PowerShell:masterfrom
PaulHigin:fix-startjob-wd-withtrailingbackslash

Conversation

@PaulHigin

Copy link
Copy Markdown
Contributor

PR Summary

This fixes a bug where a working directory path with a trailing back slash causes Start-Job to fail.

PR Context

Windows command line parsing will drop any trailing back slash in the argument list. The fix is to escape all back slash characters in the Start-Job working directory path, before including it in the argument list.

PR Checklist

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 12, 2019
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 12, 2019
@adityapatwardhan

Copy link
Copy Markdown
Member

Steve Lee (@SteveL-MSFT) - Please update your review.

@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit bd0e30d into PowerShell:master Nov 16, 2019
@iSazonov Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 16, 2019
@iSazonov Ilya (iSazonov) added this to the 7.0.0-preview.6 milestone Nov 16, 2019
@PaulHigin
Paul Higinbotham (PaulHigin) deleted the fix-startjob-wd-withtrailingbackslash branch November 18, 2019 15:33
@ghost

Copy link
Copy Markdown

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants