Resolve -WindowStyle Hidden console flashing#10965
Resolve -WindowStyle Hidden console flashing#10965iSazonov wants to merge 7 commits intoPowerShell:masterfrom
Conversation
src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs
Show resolved
Hide resolved
|
@daxian-dbw #10962 is direct implementation of pwshw idea. pwshw is only one option from many in the complex topic dicussed in #3028. The PR seems add more flexibility and allow to experiment with console, non-console, pseudo-console and GUI modes, allow to implement pwshw in the same way as we did for |
|
You'd better add the PR description about what you are doing in this PR, so a reviewer would know. |
|
@daxian-dbw Already done. Update: I think follow work should be:
|
|
Just so you’re aware, attaching to the parent process’s console as a Windows subsystem application ( You’ll probably see this: (One prompt from CMD, one from powershell, both running and reading input simultaneously.) This is impossible to work around without...
|
|
Attaching back to the parent’s console handle can also make the console fail to exit because a Windows subsystem application is still attached to it. This happens when you run |
|
@DHowett-MSFT Thanks! The scenario you describe is "Start-Process -NoNewWindow". We have an issue for it. I agree that we can not resolve it in simple way. |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
PR Summary
Fix #3028
PR Context
#10962 is direct implementation of pwshw idea. pwshw is only one option from many in the complex topic dicussed in #3028. The PR seems add more flexibility and allow to experiment with console, non-console, pseudo-console and GUI modes, allow to implement pwshw in the same way as we did for
preview-pwsh, and also fix-WindowStyle Hiddenscenario.Update: I think follow work should be:
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.