Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@ static ExperimentalFeature()
new ExperimentalFeature(
name: "PSNullConditionalOperators",
description: "Support the null conditional member access operators in PowerShell language"),
new ExperimentalFeature(
name: "PSCultureInvariantReplaceOperator",
description: "Use culture invariant to-string convertor for lval in replace operator"),
};
EngineExperimentalFeatures = new ReadOnlyCollection<ExperimentalFeature>(engineFeatures);

Expand Down
10 changes: 9 additions & 1 deletion src/System.Management.Automation/engine/lang/parserutils.cs
Original file line number Diff line number Diff line change
Expand Up @@ -967,7 +967,15 @@ internal static object ReplaceOperator(ExecutionContext context, IScriptExtent e
IEnumerator list = LanguagePrimitives.GetEnumerator(lval);
if (list == null)
{
string lvalString = lval?.ToString() ?? string.Empty;
string lvalString;
if (ExperimentalFeature.IsEnabled("PSCultureInvariantReplaceOperator"))
{
lvalString = PSObject.ToStringParser(context, lval) ?? string.Empty;
}
else
{
lvalString = lval?.ToString() ?? string.Empty;
}

return ReplaceOperatorImpl(context, lvalString, rr, substitute);
}
Expand Down
31 changes: 31 additions & 0 deletions test/powershell/Language/Operators/ReplaceOperator.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,35 @@ Describe "Replace Operator" -Tags CI {
$res | Should -BeExactly "ID XXXX123"
}
}

Describe "Culture-invariance tests for -split and -replace" -Tags CI {
BeforeAll {
$skipTest = -not [ExperimentalFeature]::IsEnabled("PSCultureInvariantReplaceOperator")
if ($skipTest) {
Write-Verbose "Test Suite Skipped. The test suite requires the experimental feature 'PSCultureInvariantReplaceOperator' to be enabled." -Verbose
$originalDefaultParameterValues = $PSDefaultParameterValues.Clone()
$PSDefaultParameterValues["it:skip"] = $true
} else {
$prevCulture = [cultureinfo]::CurrentCulture
# The French culture uses "," as the decimal mark.
[cultureinfo]::CurrentCulture = 'fr'
}
}

AfterAll {
if ($skipTest) {
$global:PSDefaultParameterValues = $originalDefaultParameterValues
} else {
[cultureinfo]::CurrentCulture = $prevCulture
}
}

It "-split: LHS stringification is not culture-sensitive" {
1.2 -split ',' | Should -Be '1.2'
}

It "-replace: LHS stringification is not culture-sensitive" {
1.2 -replace ',' | Should -Be '1.2'
}
}
}
3 changes: 2 additions & 1 deletion test/tools/TestMetadata.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"ExperimentalFeatures": {
"ExpTest.FeatureOne": [ "test/powershell/engine/ExperimentalFeature/ExperimentalFeature.Basic.Tests.ps1" ]
"ExpTest.FeatureOne": [ "test/powershell/engine/ExperimentalFeature/ExperimentalFeature.Basic.Tests.ps1" ],
"PSCultureInvariantReplaceOperator": [ "test/powershell/Language/Operators/ReplaceOperator.Tests.ps1" ]
}
}