Skip to content

Update the dotnet SDK install script URL in build.psm1 #10927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 1 commit into from
Oct 28, 2019
Merged

Update the dotnet SDK install script URL in build.psm1 #10927

TravisEz13 merged 1 commit into from
Oct 28, 2019

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Oct 28, 2019 •
edited
Loading

PR Summary

The dotnet-install.ps1 and dotnet-install.sh scripts are moved to a different URL, so update the build.psm1 to use the new URL.

PS> curl -sO "https://dot.net/v1/dotnet-install.ps1"
PS> curl -sO "https://dot.net/v1/dotnet-install.sh"

PS> cat ./dotnet-install.ps1
<head><title>Document Moved</title></head>
<body><h1>Object Moved</h1>This document may be found <a HREF="https://dotnet.microsoft.com/download/dotnet-core/scripts/v1/dotnet-install.ps1">here</a></body>
PS> cat ./dotnet-install.sh 
<head><title>Document Moved</title></head>
<body><h1>Object Moved</h1>This document may be found <a HREF="https://dotnet.microsoft.com/download/dotnet-core/scripts/v1/dotnet-install.sh">here</a></body>

PR Checklist

@TravisEz13
Copy link
Member

TravisEz13 commented Oct 28, 2019

@PoshChan Please remind me in 1 hour.

bergmeister
bergmeister approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't believe the .Net team made this breaking change without any announcement @terrajobst
Please merge this ASAP

@bergmeister
Copy link
Contributor

bergmeister commented Oct 28, 2019

@TravisEz13 This is your reminder ;-)

@TravisEz13 TravisEz13 merged commit 0effc64 into PowerShell:master Oct 28, 2019
@TravisEz13
Copy link
Member

TravisEz13 commented Oct 28, 2019

@bergmeister And they specifically told use they would support that URL.

@PoshChan
Copy link
Collaborator

PoshChan commented Oct 28, 2019

@TravisEz13, this is the reminder you requested 1 hour. ago

@daxian-dbw daxian-dbw deleted the fixbuild branch October 28, 2019 23:34
@PaulHigin PaulHigin added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 19, 2019
@PaulHigin PaulHigin added this to the 7.0.0-preview.6 milestone Nov 19, 2019
@ghost
Copy link

ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jan 27, 2020

🎉v6.2.4 has been released which incorporates this pull request.:tada:

Handy links:

TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Feb 25, 2020
@daxian-dbw @adityapatwardhan
Update the dotnet SDK install script URL in build.psm1 (PowerShell#…
c9d5fad 
…10927)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

+1 more reviewer

@bergmeister bergmeister bergmeister approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

6.2.4

Development

Successfully merging this pull request may close these issues.

6 participants

@daxian-dbw @TravisEz13 @bergmeister @PoshChan @adityapatwardhan @PaulHigin