-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Cleanups in command discovery #10815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PoshChan
reviewed
Oct 17, 2019
PoshChan
reviewed
Oct 17, 2019
PoshChan
reviewed
Oct 17, 2019
68d64dd to
581670f
Compare
PoshChan
reviewed
Oct 17, 2019
PoshChan
reviewed
Oct 17, 2019
PoshChan
reviewed
Oct 17, 2019
PoshChan
reviewed
Oct 17, 2019
fe736e5 to
c4554bc
Compare
c4554bc to
1cb0ea6
Compare
PoshChan
reviewed
Nov 19, 2019
SteveL-MSFT
approved these changes
Dec 2, 2019
Member
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One NIT for consistency
14f7a30 to
31ef215
Compare
PoshChan
reviewed
Dec 3, 2019
PoshChan
reviewed
Dec 3, 2019
PoshChan
reviewed
Dec 3, 2019
src/Microsoft.PowerShell.Commands.Management/commands/management/ComputerUnix.cs
Outdated
Show resolved
Hide resolved
PoshChan
reviewed
Dec 3, 2019
src/Microsoft.PowerShell.Commands.Management/commands/management/ComputerUnix.cs
Outdated
Show resolved
Hide resolved
a070d2c to
be15c40
Compare
be15c40 to
0e95719
Compare
Collaborator
Author
|
Fix HelpUri for Stop-Computer to pass CIs on Unix. |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CL-CodeCleanup
Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Some cleanups in the command discovery code after investigating a performance:
PR Context
Related to #6577.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.