Get-Command: Specifying an alias and -Syntax returns the aliased commands syntax #10784

ChrisLGardner · 2019-10-13T19:37:07Z

PR Summary

Add an additional check into the IsCommandMatch method to return the syntax of an aliased command rather than just the name of the aliased command.

Previous behaviour:

New behaviour:

PR Context

#5963 asked for this functionality as currently Get-Command del -syntax doesn't give you anything useful, especially not beyond what Get-Command del does. The Issue does suggest that instead of the original command it shows the alias in the syntax but the Syntax property is read-only and I didn't want to mess around with the base CommandInfo or AliasInfo object for something like this, not doing that also somewhat enables @KirkMunro's request that it shows the alias -> real command as part of the output since it'll now show the resolved command name in the syntax'

I don't think this is a breaking change because the likelihood of anyone actually using Get-Command -Name <alias> -Syntax for anything outside the command line is very minimal. I'm also not sure if there needs to be a docs change for it but it might be useful just so users are aware that it'll do this now.

PR Checklist

src/System.Management.Automation/engine/GetCommandCommand.cs

iSazonov · 2019-10-14T09:40:54Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Command.Tests.ps1

To make the tests reliable we need to load Microsoft.PowerShell.Management module.
Please add this in BeforeAll block

I think I've added it in the right place, I couldn't see any other examples of how to do it so figured a simple Import-Module Microsoft.PowerShell.Management would be enough.

iSazonov · 2019-10-14T14:09:46Z

@daxian-dbw It seems there is a problem with TestAppDomainProcessExitEvenHandlerNotLeaking test. Could you please look?
https://powershell.visualstudio.com/PowerShell/_build/results?buildId=35043&view=logs&jobId=3057ddcd-9849-50b7-e99e-f5fc6d303bb4&taskId=ff5d329a-0734-5136-788e-29ee918190af&lineStart=9&lineEnd=24&colStart=1&colEnd=27

Description: PSTests.Sequential.RunspaceTests PSTests.Sequential.RunspaceTests PSTests.Sequential.RunspaceTests PSTests.Sequential.RunspaceTests
Name:        TestAppDomainProcessExitEvenHandlerNotLeaking TestRunspaceWithPowerShellAndInitialSessionState TestRunspaceWithPipeline TestRunspaceWithPowerShell
message:
Test-XUnitTestResults : Cannot validate argument on parameter 'message'. The argument is null or empty. Provide an 
argument that is not null or empty, and then try the command again.
At D:\a\_temp\85b7acd9-47dd-489a-a2cb-ec41b0000555.ps1:5 char:1
+ Test-XUnitTestResults -TestResultsFile $xUnitTestResultsFile
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (:) [Test-XUnitTestResults], ParameterBindingValidationException
    + FullyQualifiedErrorId : ParameterArgumentValidationError,Test-XUnitTestResults

KirkMunro · 2019-10-14T15:06:14Z

The Issue does suggest that instead of the original command it shows the alias in the syntax but the Syntax property is read-only and I didn't want to mess around with the base CommandInfo or AliasInfo object for something like this, not doing that also somewhat enables @KirkMunro's request that it shows the alias -> real command as part of the output since it'll now show the resolved command name in the syntax'.

You don't need to change the Syntax property for this. Get-Command ... -Syntax returns a single string. All you need to do to show a more meaningful (and technically more correct) output is to modify the syntax strings you retrieve from the command associated with that alias, by replacing the leading command name with the name of the alias.

i.e. When you discover that it is an alias, store the alias name, and then later when you retrieve the command syntax, replace the command name with the alias name in the output, while also pre-pending that output with a comment showing the alias to command relationship.

This will be very helpful when an alias references a script path, because you'll see the alias in the output syntax (which is the command you requested syntax for), while also seeing that the command you're requesting syntax for is actually an alias for another command (good for awareness/educational purposes).

I'd really like to see the output from this match something more along these lines:

# First, create a script file
@'
[CmdletBinding()]
param(
    [Parameter(Position=0, Mandatory, ValueFromPipeline, ValueFromPipelineByPropertyName)]
    [ValidateNotNullOrEmpty()]
    [string[]]
    $Name
)
process {
    "Processing ${Name}"
}
'@ | out-File ${env:USERPROFILE}\Test-GcmSyntax.ps1

# Now set up an alias for that file
new-alias tgs ${env:USERPROFILE}\Test-GcmSyntax.ps1

# Get the command syntax using the alias
gcm -syntax tgs

Desired output:

tgs is an alias for C:\Users\kirka\Test-GcmSyntax.ps1

tgs [-Name] <string[]> [<CommonParameters>]

To make that work, you can inject the alias definition at the top (wrapping a script path in quotes if it has spaces), and then use regex to replace "^Test-GcmSyntax.ps1" (or an actual command name if it was an alias for a command instead of for a script) with "tgs".

If we don't agree on showing the alias definition at the top, at a minimum I would expect the syntax to show the alias name instead of the command/script it points to.

As an alternative, we could leave the syntax as-is, and just show the alias note at the top so that users see first that they asked for syntax for an alias, and then they see the syntax for the command that is being aliased.

As another alternative, we could show the alias details in verbose output instead, so that users only see it when invoking the command with -Verbose. I don't love that though because people should realize when they are looking at an alias, so we really need to show them that detail. They see that when they invoke Get-Command without -Syntax, but they should really see it when they invoke it with -Syntax as well.

ChrisLGardner · 2019-10-14T15:25:24Z

I've been digging into doing that a bit and I've managed to get this so far:

[547.63 ms]github\powershell [get-command-alias ≡ +0 ~1 -0 !]>  gcm del -syn
Note: del is an alias for Remove-Item

del [-Path] <string[]> [-Filter <string>] [-Include <string[]>] [-Exclude <string[]>] [-Recurse] [-Force] [-Credential <pscredential>] 
[-WhatIf] [-Confirm] [-Stream <string[]>] [<CommonParameters>]

del -LiteralPath <string[]> [-Filter <string>] [-Include <string[]>] [-Exclude <string[]>] [-Recurse] [-Force] [-Credential <pscredential>] [-WhatIf] [-Confirm] [-Stream <string[]>] [<CommonParameters>]

It doesn't bring back the full path for a script but I'll see what I can do about that. I do like the extra information that shows what the alias is for in a more clear way than just replacing the name in the syntax output.

ChrisLGardner · 2019-10-14T15:51:19Z

After a bit more fiddling around I've got it working with external scripts, I need to add some test cases for this and need to play around with it and native commands to see how that comes out.

PS>  gcm -syntax tgs
Note: tgs is an alias for C:\Users\Chris\Test-GcmSyntax.ps1
tgs [-Name] <string[]> [<CommonParameters>]

vexx32 · 2019-10-14T16:36:13Z

You can probably relay the information that it's an alias a bit more succinctly, similarly to how Get-Alias shows it; tgs -> C:\Users\Chris\Test-GcmSyntax.ps1 or gci -> Get-ChildItem

I do think having a line break after the "hey this is an alias" line is a good idea too, it helps clarify that the information being given is in two parts. 🙂

ChrisLGardner · 2019-10-14T16:40:38Z

I do think having a line break after the "hey this is an alias" line is a good idea too, it helps clarify that the information being given is in two parts. 🙂

That's what I'm thinking, it'll take a bit more conditional formatting as the syntax for a command already includes the leading line breaks but I can add that in easily enough.

KirkMunro · 2019-10-14T17:04:36Z

You can probably relay the information that it's an alias a bit more succinctly, similarly to how Get-Alias shows it; tgs -> C:\Users\Chris\Test-GcmSyntax.ps1 or gci -> Get-ChildItem

Except with Get-Alias, you know what you're getting, so seeing the shorthand such as gci -> Get-ChildItem makes more sense. You have context in that scenario to work with the information that is presented to you.

With Get-Command, you don't have the type of the command in the output, so gci -> Get-ChildItem by itself may not make as much sense unless you're familiar with that output already.

KirkMunro · 2019-10-14T17:22:51Z

Something shorter would be good though, especially if it doesn't need to be localized. Maybe something like this:

gci (alias) -> Get-ChildItem

tgs (alias) -> C:\Users\Chris\Test-GcmSyntax.ps1

You wouldn't need to quote the right-hand side of the -> if the path contained spaces with that syntax.

iSazonov · 2019-10-14T17:24:11Z

src/System.Management.Automation/engine/GetCommandCommand.cs

And how does output look with the replace?

Also I see you checking for wildcards. Is the logic smart enough to show the alias properly if a wildcard search finds commands that are aliases and outputs the syntax for them? There should probably be a specific test just for that scenario to make sure it is covered.

For scripts it looks like this:

PS> gcm tgs -syn tgs -> C:\Users\Chris\Test-GcmSyntax.ps1 tgs [-Name] <string[]> [<CommonParameters>]

For commands it's:

PS> gcm del -syn del -> Remove-Item del [-Path] <string[]> [-Filter <string>] [-Include <string[]>] [-Exclude <string[]>] [-Recurse] [-Force] [-Credential <pscredential>] [-WhatIf] [-Confirm] [-Stream <string[]>] [<CommonParameters>] del -LiteralPath <string[]> [-Filter <string>] [-Include <string[]>] [-Exclude <string[]>] [-Recurse] [-Force] [-Credential <pscredential>] [-WhatIf] [-Confirm] [-Stream <string[]>] [<CommonParameters>]

Also I see you checking for wildcards. Is the logic smart enough to show the alias properly if a wildcard search finds commands that are aliases and outputs the syntax for them? There should probably be a specific test just for that scenario to make sure it is covered.

Not right now, I need to add something in for that.

With the codefactor tests complaining about it being too complex I'll break out this into it's own method as it'll need to handle this case too and that'll make it more difficult to follow I think.

I don't like last commits. I think it is a task for Get-Help to return enhanced information in human format.

@iSazonov Actually, it's a task for Get-Command, and that's exactly what it does.

Get-Command gci shows you that gci is an alias for Get-Command.

With this PR, Get-Command gci -Syntax shows you the syntax for the gci command and also identifies that it's an alias for Get-ChildItem.

There's no reason to force users to have to call Get-Command twice to get such important information.

In fact, it would probably be far more useful for a less experienced user if -Syntax reported this additional information, as if the user had $PSDefaultParameterValues['Get-Command:Syntax'] = $true in their profile, because unless they are programmatically working with command metadata or trying to find out what module a command comes from, this information is far more useful for them.

There's no reason to force users to have to call Get-Command twice to get such important information.

Get-Help is for users to get all in once. Get-Command is more for scripting - without -Syntax it returns typed object (AliasInfo or CommandInfo) and I'd even expect that -Syntax returns typed output too as a syntax tree.

New commits

KirkMunro · 2019-10-15T11:46:38Z

In practice Get-Command is also taught as a learning tool, and it is used interactively with -Syntax very, very frequently as a way to simply get the syntax of a command. It also just returns a string.

That said, this part of the discussion makes me wonder if Get-Help should have a -Syntax parameter. The challenge there is muscle memory for users who have been using gcm -syntax for quick command inspection for years...

kilasuit · 2019-10-15T22:44:54Z

that said, this part of the discussion makes me wonder if Get-Help should have a -Syntax parameter.

I think maybe but thats a separate issue than this and whilst get-command already has syntax (and is in muscle memory) let's get improvements made to it

ChrisLGardner · 2019-10-17T10:47:55Z

I've added support for wildcards, with the correct alias for each command found replacing it's use in the syntax. If a command doesn't have an alias but is found with the wildcard then the extra notation isn't shown (see Split-Path example below)

PS>  gcm sp* -syn
sp (alias) -> Set-ItemProperty

sp [-Path] <string[]> [-Name] <string> [-Value] <Object> [-PassThru] [-Force] [-Filter <string>] [-Include <string[]>] [-Exclude <string[]>] [-Credential <pscredential>] [-WhatIf] [-Confirm] [<CommonParameters>]

sp [-Path] <string[]> -InputObject <psobject> [-PassThru] [-Force] [-Filter <string>] [-Include <string[]>] [-Exclude <string[]>] [-Credential <pscredential>] [-WhatIf] [-Confirm] [<CommonParameters>]

sp [-Name] <string> [-Value] <Object> -LiteralPath <string[]> [-PassThru] [-Force] [-Filter <string>] [-Include <string[]>] [-Exclude <string[]>] [-Credential <pscredential>] [-WhatIf] [-Confirm] [<CommonParameters>]

sp -LiteralPath <string[]> -InputObject <psobject> [-PassThru] [-Force] [-Filter <string>] [-Include <string[]>] [-Exclude <string[]>] 
[-Credential <pscredential>] [-WhatIf] [-Confirm] [<CommonParameters>]


Split-Path [-Path] <string[]> [-Parent] [-Resolve] [-Credential <pscredential>] [<CommonParameters>]  

Split-Path [-Path] <string[]> [-Leaf] [-Resolve] [-Credential <pscredential>] [<CommonParameters>]

There is one odd case that I'm not sure what to do about, if an alias and the command it's for both match a wildcard then what should the output look like. An example is write and Write-Output, currently with this implementation it'll produce output like this when you run gcm wri* -syn:

write (alias) -> Write-Output

write [-InputObject] <psobject> [-NoEnumerate] [<CommonParameters>]

But I don't think it should, it should either produce the old output of just the Write-Output or it should output both. There is duplicate detection in place to prevent outputting multiple of the same command so I'm thinking we probably want to just output the actual Write-Output syntax without the extra alias information.

ChrisLGardner · 2019-10-17T11:42:07Z

I've discovered another issue this will have, if you do something like gcm get-help, sls -syntax then it'll replace all the mentions of sls with Get-Help:

get-help (alias) -> Select-String

get-help [-Pattern] <string[]> [-Path] <string[]> [-SimpleMatch] [-CaseSensitive] [-Quiet] [-List] [-NoEmphasis] [-Include <string[]>] 
[-Exclude <string[]>] [-NotMatch] [-AllMatches] [-Encoding <Encoding>] [-Context <int[]>] [<CommonParameters>]

get-help [-Pattern] <string[]> -InputObject <psobject> [-SimpleMatch] [-CaseSensitive] [-Quiet] [-List] [-NoEmphasis] [-Include <string[]>] [-Exclude <string[]>] [-NotMatch] [-AllMatches] [-Encoding <Encoding>] [-Context <int[]>] [<CommonParameters>]

So I need to figure out a way to handle that but I know what's causing it so that's a start.

ChrisLGardner · 2019-10-18T10:24:00Z

I think I've fixed all the edge cases I can, the only one that's outstanding is if someone does gcm del, sp* -syntax then they'll get back the right output but instead of del being used for the alias in the Remove-Item output it'll actually be ri due to the order they are in the alias table. This only happens on commands with multiple aliases and when using a wildcard as well. I can't imagine people are often going to look for syntax on multiple aliases and a wildcard at the same time so I didn't put much effort into figuring out how to fix that.

This is now ready for a review since I refactored it into a new method.

src/System.Management.Automation/engine/GetCommandCommand.cs

ChrisLGardner · 2019-11-01T12:45:17Z

@SteveL-MSFT or @adityapatwardhan Can I get one of you to review this PR when you get a chance please?

SteveL-MSFT · 2019-11-01T18:10:27Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Command.Tests.ps1

NIT: Personally, would prefer the herestring to be assigned to a variable and use Set-Content on a different line as I think it's more readable

Suggested change

'@ | out-File TestDrive:\Test-GcmSyntax.ps1

'@ | Out-File -Path TestDrive:\Test-GcmSyntax.ps1

SteveL-MSFT · 2019-11-01T18:12:01Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Command.Tests.ps1

Suggested change

new-alias tgs TestDrive:\Test-GcmSyntax.ps1

new-alias tgs TestDrive:\Test-GcmSyntax.ps1

Suggested change

new-alias tgs TestDrive:\Test-GcmSyntax.ps1

New-Alias -Name tgs -Value TestDrive:\Test-GcmSyntax.ps1

SteveL-MSFT · 2019-11-01T18:15:51Z

src/System.Management.Automation/engine/GetCommandCommand.cs

You repeat this line in each case, you can have it outside the switch statement

They are slightly different as the output will need to vary depending on what is found for the alias/wildcard. If the found command is a script then it's path needs to be added along with an extra new line as the syntax property of commands already includes a leading new line.

I'm referring specifically to:

syntax = PSObject.AsPSObject(replacedSyntax);

Unless my eyes are missing something isn't it exactly the same in each case statement before the break?

Good spot, I hadn't noticed that. I've fixed that now to only happen once after the switch.

src/System.Management.Automation/engine/GetCommandCommand.cs

SteveL-MSFT · 2019-11-08T21:07:06Z

@iSazonov I think we all can agree that an object should be returned, but is outside the scope of this PR since returning a string is the existing behavior

SteveL-MSFT

LGTM

vexx32 · 2019-11-08T21:11:41Z

@PoshChan please retry windows

PoshChan · 2019-11-08T21:12:13Z

@vexx32, successfully started retry of PowerShell-CI-Windows

adityapatwardhan · 2019-12-02T20:09:31Z

@ChrisLGardner I tried building your branch and am seeing some issues. This happens when a new pwsh.exe is started and the first command is Get-Command del -Syntax. Please have a look:

PS> Get-Command del -Syntax
Get-Command: The term 'del' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

Suggestion [4,General]: The most similar commands are: del, dir, dbp, fl, gal, gl, iex, nal, sal, sl.
PS> Get-Command del -Syntax
Get-Command: The term 'del' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

Suggestion [4,General]: The most similar commands are: del, dir, dbp, fl, gal, gl, iex, nal, sal, sl.
PS> Get-Command del -Syntax
Get-Command: The term 'del' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

Suggestion [4,General]: The most similar commands are: del, dir, dbp, fl, gal, gl, iex, nal, sal, sl.
PS> Get-Command del -Syntax
Get-Command: The term 'del' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

Suggestion [4,General]: The most similar commands are: del, dir, dbp, fl, gal, gl, iex, nal, sal, sl.
PS> Get-Command del

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Alias           del -> Remove-Item

PS> Get-Command del -Syntax
del (alias) -> Remove-Item

del [-Path] <string[]> [-Filter <string>] [-Include <string[]>] [-Exclude <string[]>] [-Recurse] [-Force] [-Credential <pscredential>] [-WhatIf] [-Confirm] [-Stream <string[]>] [<CommonParameters>]

del -LiteralPath <string[]> [-Filter <string>] [-Include <string[]>] [-Exclude <string[]>] [-Recurse] [-Force] [-Credential <pscredential>] [-WhatIf] [-Confirm] [-Stream <string[]>] [<CommonParameters>]

ChrisLGardner · 2019-12-02T20:59:41Z

That's really weird, I'd not seen it before because it was auto loading my profile and that must be doing something to get around that.

I'll have a look into it over the next day or two and see if I can figure out what's going on there.

ChrisLGardner · 2019-12-08T21:10:02Z

@adityapatwardhan It looks like an issue in the session state and is in Preview 5 too. It looks like not all aliases are having their ResolvedCommand and other properties populated properly until after at least one command is successfully ran first. If you do Get-Alias gci | Format-List * you'll see ResolveCommand and a bunch of others are empty and that's what's causing this to fail.

I'll log a separate issue about this as it's outside the scope of this PR and way out of my knowledge area.

KirkMunro · 2019-12-08T22:47:14Z

@ChrisLGardner I took a quick look at this, and the issue is module auto-loading.

In a new session loaded without a profile, if I invoke gcm -syntax saps, I get information about saps being an alias for Start-Process, but the Microsoft.PowerShell.Management module does not auto-load.

If in that same session I invoke gcm -syntax Start-Process, then I get the module is auto-loaded and I get the command syntax.

This makes me think it might be in scope for this PR. Whatever Get-Command does when you pass it a command name that results in the module auto-loading should happen when you pass it an alias name, with it auto-loading the module that contains that command before it pulls information about that command so that it can show the proper information.

Note that I say all of this without looking at the code, so this is theoretical, but I think that this work is related enough to this PR and shouldn't be too difficult to figure out since gcm already worked for cmdlets in modules that were not loaded yet.

Return aliased command syntax instead of the name of the aliased command

…and location

…n the helper method

ChrisLGardner · 2019-12-14T15:19:40Z

@KirkMunro thanks for the pointer there, I managed to find the method in CommandDiscovery that was already being used for command resolution and added an extra check in to call that if it hasn't resolved the alias to a CommandInfo.

@adityapatwardhan looks like I've resolved that bug if you get a chance to look at this again at some point.

adityapatwardhan · 2019-12-20T23:41:21Z

src/System.Management.Automation/engine/GetCommandCommand.cs

Seems this will be dead code now? Is that correct?

@ChrisLGardner ping..

No, doing some testing and it's there to resolve the command name if the module the alias is in hasn't been loaded yet and then that can be used to get the syntax. Without it you get the below behaviour:

PS> gcm del -syn Remove-Item

with it you get this:

PS> gcm del -syn del (alias) -> Remove-Item del [-Path] <string[]> [-Filter <string>] [-Include <string[]>] [-Exclude <string[]>] [-Recurse] [-Force] [-Credential <pscredential>] del -LiteralPath <string[]> [-Filter <string>] [-Include <string[]>] [-Exclude <string[]>] [-Recurse] [-Force] [-Credential <pscredential>] [-WhatIf] [-Confirm] [-Stream <string[]>] [<CommonParameters>]

@ChrisLGardner I think @adityapatwardhan is referring to the line 1312 if (current == null) code path, which shouldn't be reached anymore since you're checking for null and accounting for that directly. If whatever's in that code path isn't reachable anymore, it should be removed. 🙂

Also, this condition with the null can be simplified:

current = ai.ResolvedCommand ?? CommandDiscovery.LookupCommandInfo( ai.UnresolvedCommandName, this.MyInvocation.CommandOrigin, this.Context);

Good point, I'll get that fixed now.

Looking at the failure in the tests there's a reason that check is there. It can sometimes return null from LookupCommandInfo. In the case for the tests (and locally) it is because spvm has a null ResolvedCommand and UnresolvedCommandName, probably in my case because I've apparently got both 1.1 and 2.0.0.0 of Hyper-V installed and I'd guess the AzDOS agents are similar.

Might want to add a comment explaining that so nobody tries to remove that later 🙂

…t if module is not imported

ChrisLGardner · 2020-03-27T17:06:10Z

Looks like the last failing build is related to Test-Connection so not impact by the change I've made. though I'm certainly well behind master now but I can rebase if required.

vexx32 · 2020-03-27T17:21:34Z

@PoshChan please retry macos

PoshChan · 2020-03-27T17:21:57Z

@vexx32, successfully started retry of PowerShell-CI-macOS

ghost · 2020-04-23T18:02:53Z

🎉v7.1.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

ChrisLGardner commented Oct 13, 2019

View reviewed changes

src/System.Management.Automation/engine/GetCommandCommand.cs Outdated Show resolved Hide resolved

iSazonov reviewed Oct 14, 2019

View reviewed changes

iSazonov requested review from SteveL-MSFT and adityapatwardhan October 14, 2019 09:42

iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 14, 2019

iSazonov added this to the 7.0.0-preview.5 milestone Oct 14, 2019

iSazonov previously approved these changes Oct 14, 2019

View reviewed changes

iSazonov changed the title ~~Get-Command: Specifying an alias and -Syntax returns the aliased commands syntax~~ WIP: Get-Command: Specifying an alias and -Syntax returns the aliased commands syntax Oct 14, 2019

iSazonov reviewed Oct 14, 2019

View reviewed changes

vexx32 reviewed Oct 18, 2019

View reviewed changes

src/System.Management.Automation/engine/GetCommandCommand.cs Outdated Show resolved Hide resolved

ChrisLGardner changed the title ~~WIP: Get-Command: Specifying an alias and -Syntax returns the aliased commands syntax~~ Get-Command: Specifying an alias and -Syntax returns the aliased commands syntax Oct 19, 2019

iSazonov modified the milestones: 7.0.0-preview.5, 7.0.0-preview.6 Oct 24, 2019

SteveL-MSFT requested changes Nov 1, 2019

View reviewed changes

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 1, 2019

SteveL-MSFT approved these changes Nov 8, 2019

View reviewed changes

SteveL-MSFT assigned adityapatwardhan Nov 8, 2019

TravisEz13 modified the milestones: 7.0.0-preview.6, 7.0.0-rc.1, 7.1.0-preview.1 Nov 22, 2019

ChrisLGardner mentioned this pull request Dec 8, 2019

Not all aliases have full properties in a new session #11294

Closed

ChrisLGardner added 3 commits December 14, 2019 14:15

Add additional check for alias and syntax switch

06bf207

Return aliased command syntax instead of the name of the aliased command

Add support for aliases to script files returning the correct syntax …

29dab33

…and location

Refactor output creation to its own method to reduce complexity withi…

7fdb4d0

…n the helper method

adityapatwardhan reviewed Dec 20, 2019

View reviewed changes

Add check for null resolved name and lookup actual command info objec…

891092d

…t if module is not imported

daxian-dbw modified the milestones: 7.1.0-preview.1, 7.1.0-preview.2 Apr 1, 2020

adityapatwardhan approved these changes Apr 13, 2020

View reviewed changes

adityapatwardhan merged commit 8869e7a into PowerShell:master Apr 13, 2020

sdwheeler mentioned this pull request May 20, 2020

Specifying an alias and -Syntax to Get-Command returns the aliased commands syntax MicrosoftDocs/PowerShell-Docs#5974

Closed

12 tasks

vexx32 mentioned this pull request Jun 4, 2020

Invoking commands via CommandInfo objects fails in pwsh 7 #12888

Closed

	'@ \| out-File TestDrive:\Test-GcmSyntax.ps1
	'@ \| Out-File -Path TestDrive:\Test-GcmSyntax.ps1

	new-alias tgs TestDrive:\Test-GcmSyntax.ps1
	new-alias tgs TestDrive:\Test-GcmSyntax.ps1

	new-alias tgs TestDrive:\Test-GcmSyntax.ps1
	New-Alias -Name tgs -Value TestDrive:\Test-GcmSyntax.ps1

Get-Command: Specifying an alias and -Syntax returns the aliased commands syntax #10784

Get-Command: Specifying an alias and -Syntax returns the aliased commands syntax #10784

Uh oh!

Conversation

ChrisLGardner commented Oct 13, 2019

PR Summary

PR Context

PR Checklist

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iSazonov commented Oct 14, 2019

Uh oh!

KirkMunro commented Oct 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChrisLGardner commented Oct 14, 2019

Uh oh!

ChrisLGardner commented Oct 14, 2019

Uh oh!

vexx32 commented Oct 14, 2019

Uh oh!

ChrisLGardner commented Oct 14, 2019

Uh oh!

KirkMunro commented Oct 14, 2019

Uh oh!

KirkMunro commented Oct 14, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KirkMunro Oct 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KirkMunro commented Oct 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kilasuit commented Oct 15, 2019

Uh oh!

ChrisLGardner commented Oct 17, 2019

Uh oh!

ChrisLGardner commented Oct 17, 2019

Uh oh!

ChrisLGardner commented Oct 18, 2019

Uh oh!

Uh oh!

ChrisLGardner commented Nov 1, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

SteveL-MSFT commented Nov 8, 2019

KirkMunro commented Oct 14, 2019 •

edited

Loading

KirkMunro Oct 14, 2019 •

edited

Loading

KirkMunro commented Oct 15, 2019 •

edited

Loading