Skip to content

Renamed wrongly named file - #10659

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
kilasuit:invokeExpressionCmdlet
Oct 7, 2019
Merged

Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
kilasuit:invokeExpressionCmdlet

Conversation

@kilasuit

@kilasuit Ryan Yates (kilasuit) commented Oct 1, 2019 •

Copy link
Copy Markdown
Collaborator

PR Summary

This PR fixes the incorrectly named InvokeCommandCmdlet.cs which contained Invoke-Expression definition.

PR Context

fix #9807
Make sure file name matches intended content

PR Checklist

@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 1, 2019
@iSazonov Ilya (iSazonov) added this to the 7.0.0-preview.5 milestone Oct 1, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not very consistent in our file naming, but I believe the file name should be 'InvokeExpressionCommand.cs'.

Aditya Patwardhan (@adityapatwardhan) Will renaming a source file cause any build/packaging problems?

@daxian-dbw

Copy link
Copy Markdown
Member

I agree with Paul Higinbotham (@PaulHigin)

@kilasuit

Copy link
Copy Markdown
Collaborator Author

Paul Higinbotham (@PaulHigin) - I've locally tested that change will still build pwsh & the command runs fine & also renamed the file to InvokeExpressionCommand.cs based on your comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveL-MSFT

Copy link
Copy Markdown
Member

PoshChan-Bot (@PoshChan) please retry macos

@PoshChan

Copy link
Copy Markdown
Collaborator

Steve Lee (@SteveL-MSFT), successfully started retry of PowerShell-CI-macOS

@SteveL-MSFT

Copy link
Copy Markdown
Member

Paul Higinbotham (@PaulHigin) renaming this file shouldn't cause any issues as build csproj implicitly includes cs files rather than explicitly. packaging only cares about the binary output and not source files.

@daxian-dbw Dongbo Wang (daxian-dbw) changed the title renamed wrongly named file - fixes #9807 Renamed wrongly named file Oct 7, 2019
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit c08c7e4 into PowerShell:master Oct 7, 2019
@kilasuit
Ryan Yates (kilasuit) deleted the invokeExpressionCmdlet branch October 7, 2019 20:50
@ghost

Copy link
Copy Markdown

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InvokeCommandCmdlet.cs is actually for invoke-expression cmdlet

6 participants