Repository navigation
Renamed wrongly named file - #10659
Conversation
Paul Higinbotham (PaulHigin)
left a comment
There was a problem hiding this comment.
We are not very consistent in our file naming, but I believe the file name should be 'InvokeExpressionCommand.cs'.
Aditya Patwardhan (@adityapatwardhan) Will renaming a source file cause any build/packaging problems?
|
I agree with Paul Higinbotham (@PaulHigin) |
6a15abb to
4433029
Compare
|
Paul Higinbotham (@PaulHigin) - I've locally tested that change will still build pwsh & the command runs fine & also renamed the file to |
Paul Higinbotham (PaulHigin)
left a comment
There was a problem hiding this comment.
LGTM
|
PoshChan-Bot (@PoshChan) please retry macos |
|
Steve Lee (@SteveL-MSFT), successfully started retry of |
|
Paul Higinbotham (@PaulHigin) renaming this file shouldn't cause any issues as build csproj implicitly includes cs files rather than explicitly. packaging only cares about the binary output and not source files. |
|
🎉 Handy links: |
PR Summary
This PR fixes the incorrectly named InvokeCommandCmdlet.cs which contained Invoke-Expression definition.
PR Context
fix #9807
Make sure file name matches intended content
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.