-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Renamed wrongly named file #10659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed wrongly named file #10659
Conversation
PaulHigin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not very consistent in our file naming, but I believe the file name should be 'InvokeExpressionCommand.cs'.
@adityapatwardhan Will renaming a source file cause any build/packaging problems?
|
I agree with @PaulHigin |
6a15abb to
4433029
Compare
|
@PaulHigin - I've locally tested that change will still build pwsh & the command runs fine & also renamed the file to |
PaulHigin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@PoshChan please retry macos |
|
@SteveL-MSFT, successfully started retry of |
|
@PaulHigin renaming this file shouldn't cause any issues as build csproj implicitly includes cs files rather than explicitly. packaging only cares about the binary output and not source files. |
|
🎉 Handy links: |
PR Summary
This PR fixes the incorrectly named InvokeCommandCmdlet.cs which contained Invoke-Expression definition.
PR Context
fix #9807
Make sure file name matches intended content
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.