Skip to content

Ensure that types referenced by PowerShellStandard are present #10634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 10 commits into from
Feb 3, 2020
Merged

Ensure that types referenced by PowerShellStandard are present #10634

TravisEz13 merged 10 commits into from
Feb 3, 2020

Conversation

@JamesWTruher
Copy link
Collaborator

@JamesWTruher JamesWTruher commented Sep 26, 2019 •
edited
Loading

PR Summary

I'm adding a set of tests which validates that the types which are present in PowerShellStandard are present in PowerShell Core. This is to be sure that we don't break folks which have been using PowerShell Standard when we release a new version of Core.

PR Context

PR Checklist

@JamesWTruher JamesWTruher added the WG-DevEx-SDK hosting PowerShell as a runtime, PowerShell's APIs, PowerShell Standard, or development of modules label Sep 26, 2019
@daxian-dbw daxian-dbw added the AutoMerge informs the bot to automerge the PR label Sep 26, 2019
@ghost
Copy link

ghost commented Sep 26, 2019

Hello @daxian-dbw!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 24 hours, a condition that will be fulfilled in about 20 hours 23 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@daxian-dbw daxian-dbw added CL-Test Indicates that a PR should be marked as a test change in the Change Log and removed WG-DevEx-SDK hosting PowerShell as a runtime, PowerShell's APIs, PowerShell Standard, or development of modules labels Sep 26, 2019
iSazonov
iSazonov approved these changes Sep 27, 2019
View reviewed changes
Copy link
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comment.

iSazonov
iSazonov reviewed Sep 27, 2019
View reviewed changes
@iSazonov iSazonov added this to the 7.0.0-preview.5 milestone Sep 27, 2019
rjmholt
rjmholt reviewed Oct 3, 2019
View reviewed changes
@daxian-dbw
Copy link
Member

daxian-dbw commented Oct 9, 2019

@JamesWTruher CI builds failed and there are some feedback. Please take another look when you have time.

@ghost ghost removed the AutoMerge informs the bot to automerge the PR label Oct 22, 2019
PoshChan
PoshChan reviewed Oct 23, 2019
View reviewed changes
PoshChan
PoshChan reviewed Oct 23, 2019
View reviewed changes
@TravisEz13 TravisEz13 self-assigned this Oct 24, 2019
JamesWTruher and others added 4 commits January 28, 2020 12:29
@JamesWTruher @iSazonov
Update test/powershell/engine/Basic/StandardLibraryTypes.Tests.ps1
12a95ec 
Co-Authored-By: Ilya <darpa@yandex.ru>
@JamesWTruher @iSazonov
Update test/powershell/engine/Basic/StandardLibraryTypes.Tests.ps1
50275b9 
Co-Authored-By: Ilya <darpa@yandex.ru>
@JamesWTruher @rjmholt
Update test/powershell/engine/Basic/StandardLibraryTypes.Tests.ps1
d9e3bf6 
Co-Authored-By: Robert Holt <rjmholt_msft@outlook.com>
@JamesWTruher @rjmholt
Update test/powershell/engine/Basic/StandardLibraryTypes.Tests.ps1
869e3ae 
Co-Authored-By: Robert Holt <rjmholt_msft@outlook.com>
PoshChan
PoshChan reviewed Jan 28, 2020
View reviewed changes
PoshChan
PoshChan reviewed Jan 28, 2020
View reviewed changes
PoshChan
PoshChan reviewed Jan 28, 2020
View reviewed changes
@JamesWTruher JamesWTruher changed the title Ensure that types referenced by PowerShellStandard are present WIP: Ensure that types referenced by PowerShellStandard are present Jan 28, 2020
@JamesWTruher JamesWTruher changed the title WIP: Ensure that types referenced by PowerShellStandard are present Ensure that types referenced by PowerShellStandard are present Jan 28, 2020
@JamesWTruher
Copy link
Collaborator Author

JamesWTruher commented Jan 28, 2020

@daxian-dbw @TravisEz13 runs clean now

@TravisEz13
Copy link
Member

TravisEz13 commented Feb 3, 2020

@JamesWTruher Should this be back ported?

@TravisEz13 TravisEz13 merged commit bb8dbb9 into PowerShell:master Feb 3, 2020
@ghost
Copy link

ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

+2 more reviewers

@rjmholt rjmholt rjmholt left review comments

@PoshChan PoshChan PoshChan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.1

Development

Successfully merging this pull request may close these issues.

6 participants

@JamesWTruher @daxian-dbw @TravisEz13 @rjmholt @iSazonov @PoshChan