Skip to content

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Sep 20, 2019

PR Summary

Fix #9587

  • Make the NuGet package Microsoft.PowerShell.SDK ship the ref folder, which will be copied to the right place for dotnet build and dotnet publish.
  • Make change in Add-Type to look for the ref folder at the folder where EntryAssembly is located. In case of pwsh, it's the folder that contains pwsh.dll.
  • Add a hosting test to make sure Add-Type works for an application that hosts powershell.

PR Context

PR Checklist

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Sep 21, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.5 milestone Sep 21, 2019
@daxian-dbw
Copy link
Member Author

/cc @TylerLeonhardt

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a small change for big impact 😊 LGTM

@adityapatwardhan adityapatwardhan merged commit 7451792 into PowerShell:master Sep 25, 2019
@daxian-dbw daxian-dbw deleted the addtype branch September 25, 2019 23:26
@ghost
Copy link

ghost commented Oct 23, 2019

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jan 27, 2020

🎉v6.2.4 has been released which incorporates this pull request.:tada:

Handy links:

@TylerLeonhardt
Copy link
Member

@Francisco-Gamino fyi

TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Add-Type' doesn't work in applications that host powershell

7 participants