Skip to content

Rename default ParameterSetName back to Delimiter for ConvertTo-Csv & ConvertFrom-Csv #10425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 3 commits into from
Aug 23, 2019
Merged

Rename default ParameterSetName back to Delimiter for ConvertTo-Csv & ConvertFrom-Csv #10425

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35e0d98
rename default parameterset name back to `Delimiter`
SteveL-MSFT Aug 22, 2019
88f466f
also fix convertfrom-csv
SteveL-MSFT Aug 22, 2019
3966a71
rename parametersetname for UseCulture back to UseCulture since there…
SteveL-MSFT Aug 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/Microsoft.PowerShell.Commands.Utility/commands/utility/CsvCommands.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,7 @@ protected override void ProcessRecord()
/// <summary>
/// Implements ConvertTo-Csv command.
/// </summary>
[Cmdlet(VerbsData.ConvertTo, "Csv", DefaultParameterSetName = "DelimiterPath",
[Cmdlet(VerbsData.ConvertTo, "Csv", DefaultParameterSetName = "Delimiter",
HelpUri = "https://go.microsoft.com/fwlink/?LinkID=135203", RemotingCapability = RemotingCapability.None)]
[OutputType(typeof(string))]
public sealed class ConvertToCsvCommand : BaseCsvWritingCommand
Expand Down Expand Up @@ -744,7 +744,7 @@ public override void WriteCsvLine(string line)
/// <summary>
/// Implements ConvertFrom-Csv command.
/// </summary>
[Cmdlet(VerbsData.ConvertFrom, "Csv", DefaultParameterSetName = "DelimiterPath",
[Cmdlet(VerbsData.ConvertFrom, "Csv", DefaultParameterSetName = "Delimiter",
HelpUri = "https://go.microsoft.com/fwlink/?LinkID=135201", RemotingCapability = RemotingCapability.None)]
public sealed class ConvertFromCsvCommand : PSCmdlet
{
Expand All @@ -753,16 +753,15 @@ public sealed class ConvertFromCsvCommand : PSCmdlet
/// <summary>
/// Property that sets delimiter.
/// </summary>
[Parameter(Position = 1, ParameterSetName = "DelimiterPath")]
[Parameter(Position = 1, ParameterSetName = "Delimiter")]
[ValidateNotNull]
[ValidateNotNullOrEmpty]
public char Delimiter { get; set; }

///<summary>
///Culture switch for csv conversion
///</summary>
[Parameter(ParameterSetName = "CulturePath", Mandatory = true)]
[Parameter(ParameterSetName = "CultureLiteralPath", Mandatory = true)]
[Parameter(ParameterSetName = "UseCulture", Mandatory = true)]
[ValidateNotNull]
[ValidateNotNullOrEmpty]
public SwitchParameter UseCulture { get; set; }
Expand Down