Skip to content

Add missing experimental feature check for ForEach-Object -Parallel tests #10354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 2 commits into from
Aug 19, 2019
Merged

Add missing experimental feature check for ForEach-Object -Parallel tests #10354

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ed5b17
add missing experimental feature check
KirkMunro Aug 14, 2019
7f0cf0f
Update based on review comments
KirkMunro Aug 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 22 additions & 13 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/Foreach-Object-Parallel.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,56 +121,65 @@ Describe 'ForEach-Object -Parallel common parameters' -Tags 'CI' {

BeforeAll {

$skipTest = -not $EnabledExperimentalFeatures.Contains('PSForEachObjectParallel')
if ($skipTest) {
Write-Verbose "Test Suite Skipped. The test suite requires the experimental feature 'PSForEachObjectParallel' to be enabled." -Verbose
$originalDefaultParameterValues = $PSDefaultParameterValues.Clone()
$PSDefaultParameterValues["it:skip"] = $true
}

# Test cases
$TestCasesNotSupportedCommonParameters = @(
@{
testName = 'Verifies that ErrorAction common parameter is not supported'
testName = 'Verifies that ErrorAction common parameter is not supported'
scriptBlock = { 1..1 | ForEach-Object -Parallel { "Hello" } -ErrorAction Stop }
},
@{
testName = 'Verifies that WarningAction common parameter is not supported'
testName = 'Verifies that WarningAction common parameter is not supported'
scriptBlock = { 1..1 | ForEach-Object -Parallel { "Hello" } -WarningAction SilentlyContinue }
},
@{
testName = 'Verifies that InformationAction common parameter is not supported'
testName = 'Verifies that InformationAction common parameter is not supported'
scriptBlock = { 1..1 | ForEach-Object -Parallel { "Hello" } -InformationAction SilentlyContinue }
},
@{
testName = 'Verifies that PipelineVariable common parameter is not supported'
testName = 'Verifies that PipelineVariable common parameter is not supported'
scriptBlock = { 1..1 | ForEach-Object -Parallel { "Hello" } -PipelineVariable pipeVar }
}
)

$TestCasesForSupportedCommonParameters = @(
@{
testName = 'Verifies ErrorVariable common parameter'
scriptBlock = { 1..1 | ForEach-Object -Parallel { Write-Error "Error:$_" } -ErrorVariable global:actualVariable }
testName = 'Verifies ErrorVariable common parameter'
scriptBlock = { 1..1 | ForEach-Object -Parallel { Write-Error "Error:$_" } -ErrorVariable global:actualVariable }
expectedResult = 'Error:1'
},
@{
testName = 'Verifies WarningVarible common parameter'
scriptBlock = { 1..1 | ForEach-Object -Parallel { Write-Warning "Warning:$_" } -WarningVariable global:actualVariable }
testName = 'Verifies WarningVarible common parameter'
scriptBlock = { 1..1 | ForEach-Object -Parallel { Write-Warning "Warning:$_" } -WarningVariable global:actualVariable }
expectedResult = 'Warning:1'
},
@{
testName = 'Verifies InformationVariable common parameter'
scriptBlock = { 1..1 | ForEach-Object -Parallel { Write-Information "Information:$_"} -InformationVariable global:actualVariable }
testName = 'Verifies InformationVariable common parameter'
scriptBlock = { 1..1 | ForEach-Object -Parallel { Write-Information "Information:$_" } -InformationVariable global:actualVariable }
expectedResult = 'Information:1'
},
@{
testName = 'Verifies OutVariable common parameter'
scriptBlock = { 1..1 | ForEach-Object -Parallel {Write-Output "Output:$_"} -OutVariable global:actualVariable }
testName = 'Verifies OutVariable common parameter'
scriptBlock = { 1..1 | ForEach-Object -Parallel { Write-Output "Output:$_" } -OutVariable global:actualVariable }
expectedResult = 'Output:1'
}
)
}

BeforeEach {

$global:actualVariable = $null
}

AfterAll {
if ($skipTest) {
$global:PSDefaultParameterValues = $originalDefaultParameterValues
}

$global:actualVariable = $null
}
Expand Down