Skip to content

Deprecate internal HelpCategory.Workflow enumeration #10319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
Aug 15, 2019
Merged

Deprecate internal HelpCategory.Workflow enumeration #10319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/System.Management.Automation/help/AliasHelpInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ private AliasHelpInfo(AliasInfo aliasInfo)
this.ForwardTarget = name;
// A Cmdlet/Function/Script etc can have alias.
this.ForwardHelpCategory = HelpCategory.Cmdlet |
HelpCategory.Function | HelpCategory.ExternalScript | HelpCategory.ScriptCommand | HelpCategory.Filter | HelpCategory.Workflow;
HelpCategory.Function | HelpCategory.ExternalScript | HelpCategory.ScriptCommand | HelpCategory.Filter;

if (!string.IsNullOrEmpty(aliasInfo.Name))
{
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/help/CommandHelpProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1253,7 +1253,7 @@ private static bool Match(string target, ICollection<string> patterns)
internal override IEnumerable<HelpInfo> ProcessForwardedHelp(HelpInfo helpInfo, HelpRequest helpRequest)
{
HelpCategory categoriesHandled = (HelpCategory.Alias
| HelpCategory.ExternalScript | HelpCategory.Filter | HelpCategory.Function | HelpCategory.ScriptCommand | HelpCategory.Workflow);
| HelpCategory.ExternalScript | HelpCategory.Filter | HelpCategory.Function | HelpCategory.ScriptCommand);

if ((helpInfo.HelpCategory & categoriesHandled) != 0)
{
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/help/HelpCommands.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ private void ValidateAndThrowIfError(HelpCategory cat)
// categories that support -Parameter, -Role, -Functionality, -Component parameters
HelpCategory supportedCategories =
HelpCategory.Alias | HelpCategory.Cmdlet | HelpCategory.ExternalScript |
HelpCategory.Filter | HelpCategory.Function | HelpCategory.ScriptCommand | HelpCategory.Workflow;
HelpCategory.Filter | HelpCategory.Function | HelpCategory.ScriptCommand;

if ((cat & supportedCategories) == 0)
{
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/help/HelpRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ internal void Validate()
if ((!(Component == null && Role == null && Functionality == null)) &&
(HelpCategory == HelpCategory.None))
{
HelpCategory = HelpCategory.Alias | HelpCategory.Cmdlet | HelpCategory.Function | HelpCategory.Filter | HelpCategory.ExternalScript | HelpCategory.ScriptCommand | HelpCategory.Workflow;
HelpCategory = HelpCategory.Alias | HelpCategory.Cmdlet | HelpCategory.Function | HelpCategory.Filter | HelpCategory.ExternalScript | HelpCategory.ScriptCommand;

return;
}
Expand Down
5 changes: 0 additions & 5 deletions src/System.Management.Automation/help/HelpSystem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -908,11 +908,6 @@ internal enum HelpCategory
/// </summary>
DefaultHelp = 0x1000,

///<summary>
/// Help for a Workflow.
/// </summary>
Workflow = 0x2000,

///<summary>
/// Help for a Configuration.
/// </summary>
Expand Down
3 changes: 1 addition & 2 deletions src/System.Management.Automation/help/ScriptCommandHelpProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ internal override HelpCategory HelpCategory
HelpCategory.Filter |
HelpCategory.Function |
HelpCategory.Configuration |
HelpCategory.ScriptCommand |
HelpCategory.Workflow;
HelpCategory.ScriptCommand;
}
}

Expand Down