Skip to content

Don't collect process starttime as it's not being used on consolehost startup #10294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 2 commits into from
Aug 6, 2019
Merged

Don't collect process starttime as it's not being used on consolehost startup #10294

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f79ee7
mark _readyForInputTimeInMS member as part of LEGACYTELEMETRY
SteveL-MSFT Aug 2, 2019
035f56b
move _interactiveCommandCount to LEGACYTELEMETRY
SteveL-MSFT Aug 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHost.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1023,11 +1023,12 @@ bool IHostProvidesTelemetryData.HostIsInteractive
double IHostProvidesTelemetryData.ReadyForInputTimeInMS { get { return _readyForInputTimeInMS; } }

int IHostProvidesTelemetryData.InteractiveCommandCount { get { return _interactiveCommandCount; } }
#endif

private double _profileLoadTimeInMS;
private double _readyForInputTimeInMS;
private int _interactiveCommandCount;
#endif

private double _profileLoadTimeInMS;

#endregion overrides

Expand Down Expand Up @@ -1602,8 +1603,10 @@ private void DoCreateRunspace(string initialCommand, bool skipProfiles, bool sta
PSTask.PowershellConsoleStartup, PSKeyword.UseAlwaysOperational);
}

#if LEGACYTELEMETRY
// Record how long it took from process start to runspace open for telemetry.
_readyForInputTimeInMS = (DateTime.Now - Process.GetCurrentProcess().StartTime).TotalMilliseconds;
#endif

DoRunspaceInitialization(skipProfiles, initialCommand, configurationName, initialCommandArgs);
}
Expand Down Expand Up @@ -2517,8 +2520,10 @@ e is RemoteException ||
}
}

#if LEGACYTELEMETRY
if (!inBlockMode)
s_theConsoleHost._interactiveCommandCount += 1;
#endif
}
}
// NTRAID#Windows Out Of Band Releases-915506-2005/09/09
Expand Down