Skip to content

Identify renaming a parameter set as non-breaking in the breaking change contract document #10113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 3 commits into from
Jul 15, 2019
Merged

Identify renaming a parameter set as non-breaking in the breaking change contract document #10113

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1165fc
Identify renaming a parameter set as non-breaking
KirkMunro Jul 11, 2019
edf201f
Add note about S.M.A.Internal
KirkMunro Jul 12, 2019
29d817e
Update docs/dev-process/breaking-change-contract.md
KirkMunro Jul 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/dev-process/breaking-change-contract.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ Changes to surface area or behavior that is clearly internal or non-breaking in

Examples:

+ Changes to internal APIs that break private reflection
+ Changes to internal APIs that break private reflection.
+ Changes to APIs in the `System.Management.Automation.Internal` namespace (even if they are public, they are still considered internal and subject to change).
+ Renaming a parameter set (see related discussion [here](https://github.com/PowerShell/PowerShell/issues/10058)).

It is impossible to evolve a code base without making such changes, so we don't require up-front approval for these, but we will sometimes have to go back and
revisit such change if there's too much pain inflicted on the ecosystem through a popular app or library.
Expand Down