Skip to content

Reduce allocations in GetAssemblies() #10024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 4 commits into from
Jul 1, 2019
Merged

Reduce allocations in GetAssemblies() #10024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27be361
Reduce allocations in GetAssemblies()
iSazonov Jun 28, 2019
a8723b0
Use DynamicClassAssemblyFullName
iSazonov Jun 28, 2019
896ad16
Fix typo
iSazonov Jun 28, 2019
ca0f1c5
Rename const
iSazonov Jun 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/System.Management.Automation/engine/parser/PSType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ namespace System.Management.Automation.Language
internal class TypeDefiner
{
internal const string DynamicClassAssemblyName = "PowerShell Class Assembly";
internal const string DynamicClassAssemblyFullNamePrefix = "PowerShell Class Assembly,";

private static int s_globalCounter = 0;
private static readonly CustomAttributeBuilder s_hiddenCustomAttributeBuilder =
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/utils/ClrFacade.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ internal static IEnumerable<Assembly> GetAssemblies(string namespaceQualifiedTyp
{
return PSAssemblyLoadContext.GetAssembly(namespaceQualifiedTypeName) ??
AppDomain.CurrentDomain.GetAssemblies().Where(a =>
!TypeDefiner.DynamicClassAssemblyName.Equals(a.GetName().Name, StringComparison.Ordinal));
!a.FullName.StartsWith(TypeDefiner.DynamicClassAssemblyFullNamePrefix, StringComparison.Ordinal));
}

/// <summary>
Expand Down