-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Description
ActionPreference.Suspend is not supported in PowerShell Core (it's only used for workflows, which are not in PowerShell Core). Today it just adds confusion to the code with checks to ensure that value isn't used where there doesn't need to be any. The checks should also be performed by a PSSA rule rather than in source code (similar to ActionPreference.Ignore, as was decided in #4348). Do we need to keep ActionPreference.Suspend checks around at this point or can we just remove the half-dozen checks related to it from the source code?
Further, if we remove these checks (for the same reason we removed the checks for ActionPreference.Ignore), do we need the ActionPreference.Suspend enumeration value kept around at all?
@SteveL-MSFT: For committee review.
[Update]
As per the committee review, all workflow code should be removed. Here is the list of items requiring removal:
- workflow keyword
- parallel keyword (used for parallel activities in workflow)
- sequence keyword (used for sequential activities in workflow)
- inlinescript activity block (used for activities outside of workflow)
- -parallel parameter on foreach statement
- Checkpoint-Workflow activity (command)
- Suspend-Workflow activity (command)
- ActionPreference.Suspend enumeration
- plus all related classes/methods