-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Closed
Labels
Issue-Questionideally support can be provided via other mechanisms, but sometimes folks do open an issue to get aideally support can be provided via other mechanisms, but sometimes folks do open an issue to get aResolution-AnsweredThe question is answered.The question is answered.
Description
As per title, the CodeFactor check makes most PRs red because it flags up issues that are unrelated to the PR.
This is due to the files containing a lot of other code. Neither do I want to change unrelated code as part of the PR nor seeing the PR checks as red, we should not have a '50 shades of red' build.
The team should clean up the warnings first or suppress some of the warnings since so far most of them are purely stylistic.
.Net Core has the Microsoft.CodeAnalysis.FxCopAnalyzers NuGet package, which is a subset of the CA warnings that most people are familiar with from the full .Net framework, I found those warnings more useful rather than having a linter check, since linters are more useful when being used in VS Code extensions
Metadata
Metadata
Assignees
Labels
Issue-Questionideally support can be provided via other mechanisms, but sometimes folks do open an issue to get aideally support can be provided via other mechanisms, but sometimes folks do open an issue to get aResolution-AnsweredThe question is answered.The question is answered.