Skip to content

Address Code Cleanup Comments in PR #4318 #4596

@mirichmo

Description

@mirichmo

There are a few small code clean up comments that were not addressed in the PR. This issue documents them in case someone wants to pick up the task.

src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/ConvertToJsonCommand.cs
@@ -60,6 +61,15 @@ public class ConvertToJsonCommand : PSCmdlet
[Parameter]
public SwitchParameter Compress { get; set; }

  •    /// <summary> 
    
  •    /// gets or sets the EnumsAsStrings property. 
    

Please correct typo gets -> Gets.

test/powershell/Modules/Microsoft.PowerShell.Utility/Pester.Commands.Cmdlets.Json.Tests.ps1
+

  •        $response4 = ConvertTo-Json -InputObject $sampleObject -Compress -EnumsAsStrings 
    
  •        $response4 | Should Be '{"SampleSimpleEnum":"Ignore","SampleBitwiseEnum":"Alias, Function, Cmdlet"}' 
    

Please remove extra line.

test/powershell/Modules/Microsoft.PowerShell.Utility/Pester.Commands.Cmdlets.Json.Tests.ps1

  •        $response4 | Should Be '{"SampleSimpleEnum":"Ignore","SampleBitwiseEnum":"Alias, Function, Cmdlet"}' 
    
  •    } 
    

Please remove extra line.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue-Code Cleanupthe issue is for cleaning up the code with no impact on functionalityResolution-FixedThe issue is fixed.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions