Skip to content

installpsh-osx.sh does not install visual-studio-code from cask #4511

@DonPwrShellHunt

Description

@DonPwrShellHunt

I am posting this at the request of DarwinJS

I was reviewing the OS X installer & noticed that the brew install command for visual-studio-code did not include the cask option. On my system a "brew search visual-studio-code" clearly found the installer in cask room/cask.

Steps to reproduce

/usr/local/microsoft/powershell $ brew search visual-studio-code
caskroom/cask/visual-studio-code
caskroom/versions/visual-studio-code-insiders

Actual Code snippet

if [[ "'$*'" =~ includeide ]] ; then
    echo "\n*** Installing VS Code PowerShell IDE..."
    if [[ ! -d $(brew --prefix visual-studio-code) ]]; then
        if ! brew install visual-studio-code; then
            echo "ERROR: Visual Studio Code failed to install..." >&2
            exit 1
        fi
    else
        brew upgrade visual-studio-code
    fi

Environment Data

/usr/local/microsoft/powershell $ brew cask info powershell
powershell: 6.0.0-beta.5
https://github.com/PowerShell/PowerShell
/usr/local/Caskroom/powershell/6.0.0-beta.5 (50.8MB)
From: https://github.com/caskroom/homebrew-cask/blob/master/Casks/powershell.rb
==> Name
PowerShell
==> Artifacts
powershell-6.0.0-beta.5-osx.10.12-x64.pkg (pkg)
==> Caveats
A OpenSSL-backed libcurl is required for custom handling of certificates.
This is rarely needed, but you can install it with
  brew install curl --with-openssl
See https://github.com/PowerShell/PowerShell/issues/2211

/usr/local/microsoft/powershell $ brew cask info visual-studio-code
visual-studio-code: 1.14.2,cb82febafda0c8c199b9201ad274e25d9a76874e
https://code.visualstudio.com/
/usr/local/Caskroom/visual-studio-code/1.14.2,cb82febafda0c8c199b9201ad274e25d9a76874e (68B)
From: https://github.com/caskroom/homebrew-cask/blob/master/Casks/visual-studio-code.rb
==> Names
Microsoft Visual Studio Code
VS Code
==> Artifacts
Visual Studio Code.app (app)
/Applications/Visual Studio Code.app/Contents/Resources/app/bin/code (binary)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-Maintainers-Buildspecific to affecting the buildIssue-Questionideally support can be provided via other mechanisms, but sometimes folks do open an issue to get aResolution-FixedThe issue is fixed.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions