Fix PSScriptAnalyzer warnings and errors #3791
Description
We should be PSScriptAnalyzer clean and any new PRs should pass PSScriptAnalyzer
PS> $e = Get-ChildItem -Recurse -Include *.ps1,*.psm1 | ? { $_.fullname -notmatch "\\bin\\" } | % { Invoke-ScriptAnalyzer -Path $_ }
PS> $e | Group-Object severity
Count Name Group
----- ---- -----
1528 Warning {Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic.DiagnosticRecord, Microsoft.Win...
20 Error {Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic.DiagnosticRecord, Microsoft.Win...
129 Information {Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic.DiagnosticRecord, Microsoft.Win...