-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Closed
Labels
Issue-Enhancementthe issue is more of a feature request than a bugthe issue is more of a feature request than a bugResolution-No ActivityIssue has had no activity for 6 months or moreIssue has had no activity for 6 months or moreUp-for-GrabsUp-for-grabs issues are not high priorities, and may be opportunities for external contributorsUp-for-grabs issues are not high priorities, and may be opportunities for external contributorsWG-Enginecore PowerShell engine, interpreter, and runtimecore PowerShell engine, interpreter, and runtime
Description
There are 2 issues to address here
- The usage of
FindFirstFileNameandFindNextFileNameis disabled in powershell core at https://github.com/PowerShell/PowerShell/blob/master/src/System.Management.Automation/namespaces/FileSystemProvider.cs#L7928. Now they are available in NanoServer and IoT in the API setapi-ms-win-core-file-l1-2-2, so maybe now it's the time to enable them in powershell core. Note that this API set is not available in .net core packages by default, so we basically need to verify if thekernel32forwarder on NanoServer and IoT can correctly forward the call to the right API set. - (Fixed in Cleanup FileSystemProvider from runtime checks #7655)
FileSystemProvider.csneeds to be refactored. I spot 2 things -- (1)GetTargetandInternalGetTargetneeds to be refactored asPlatform.NonWindowsInternalGetTargetwon't be reached at all. (2) runtime checks should be converted to compilation time checks as much as possible.
Metadata
Metadata
Assignees
Labels
Issue-Enhancementthe issue is more of a feature request than a bugthe issue is more of a feature request than a bugResolution-No ActivityIssue has had no activity for 6 months or moreIssue has had no activity for 6 months or moreUp-for-GrabsUp-for-grabs issues are not high priorities, and may be opportunities for external contributorsUp-for-grabs issues are not high priorities, and may be opportunities for external contributorsWG-Enginecore PowerShell engine, interpreter, and runtimecore PowerShell engine, interpreter, and runtime