Skip to content

Add warning to web cmdlets if it defaults to HTTP #19316

@CarloToso

Description

@CarloToso

Summary of the new feature / enhancement

In WebRequestPSCmdlet.Common.cs line 1399 if we provide a -Uri with no scheme it defaults to http, is this the desired behaviour in 2023? Discussed with @iSazonov in #19162 comments

        private static Uri CheckProtocol(Uri uri)
        {
            ArgumentNullException.ThrowIfNull(uri);

            return uri.IsAbsoluteUri ? uri : new Uri("http://" + uri.OriginalString);
        }

Test:

$x = Invoke-WebRequest google.com
$x.BaseResponse.RequestMessage.RequestUri.Scheme
#--> http

Proposed technical implementation details (optional)

http --> https

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue-Enhancementthe issue is more of a feature request than a bugResolution-No ActivityIssue has had no activity for 6 months or moreUp-for-GrabsUp-for-grabs issues are not high priorities, and may be opportunities for external contributorsWG-Cmdlets-Utilitycmdlets in the Microsoft.PowerShell.Utility module

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions