-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Open
Labels
Issue-Enhancementthe issue is more of a feature request than a bugthe issue is more of a feature request than a bugKeepOpenThe bot will ignore these and not auto-closeThe bot will ignore these and not auto-closeWG-Enginecore PowerShell engine, interpreter, and runtimecore PowerShell engine, interpreter, and runtime
Description
Summary of the new feature / enhancement
The current design of IFeedbackProvider only works against an ErrorRecord. Unless $PSNativeCommandUseErrorActionPreference is $true, no ErrorRecord is created if a native command exists with a non-zero exit code. For example, I can't build a feedback provider for the git command.
Proposed technical implementation details (optional)
Perhaps FeedbackProviders should be registered with a Kind specifying when it should be enacted? I don't know if there will be other cases other than ErrorRecord and non-zero exit code.
cc @daxian-dbw
Metadata
Metadata
Assignees
Labels
Issue-Enhancementthe issue is more of a feature request than a bugthe issue is more of a feature request than a bugKeepOpenThe bot will ignore these and not auto-closeThe bot will ignore these and not auto-closeWG-Enginecore PowerShell engine, interpreter, and runtimecore PowerShell engine, interpreter, and runtime
Type
Projects
Status
Potentially for 7.4 GA