-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Closed
Labels
Resolution-FixedThe issue is fixed.The issue is fixed.WG-Enginecore PowerShell engine, interpreter, and runtimecore PowerShell engine, interpreter, and runtime
Milestone
Description
While working on the sxs module path, I found some method names are intuitive, for example, GetDscModulePath() actually returns the Program Files shared module path, GetSystemWideModulePath() actually returns the pshome module path. Those method need to be renamed.
- Refactor method names related to module path calculation
- The code that detects if a module path is PSHome module path derived from parent process needs to be smarter, not only check
powershellfile in the parent folder, but maybe checkpowershell.deps.jsonfile as well, and also the short folder name of the path should beModules. The current detection logic casued a test to fail in Travis CI, see Fix the test that fails in Travis CI build #1792 - Add more SxS module path tests
-
Think about the nameinboxofPlatform.IsInboxproperty. Do we need a better name?Platform.IsInboxis an internal property, and it's well commented to clarify its meaning. We will keep this name unless there is a big concern about it.
Metadata
Metadata
Assignees
Labels
Resolution-FixedThe issue is fixed.The issue is fixed.WG-Enginecore PowerShell engine, interpreter, and runtimecore PowerShell engine, interpreter, and runtime