Skip to content

Naming convention for internal static readonly #12819

@xtqqczze

Description

@xtqqczze

In #11777, the readonly modifier was added to internal static members which raised an issue of our naming convention.

According to StyleCopAnalyzers on CodeFactor, "readonly variables that are not declared private must start with an upper-case letter" otherwise there are violations of the rule SA1304NonPrivateReadonlyFieldsMustBeginWithUpperCaseLetter

Our naming conventions state static fields should start with s_, however the existing code overwhelmingly uses PascalCase for internal static readonly members.

In my view conventions should be descriptive rather than prescriptive, so we should consider making changes to the written naming convention.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-Maintainers-Documentationspecific to documentation in this repoIssue-Questionideally support can be provided via other mechanisms, but sometimes folks do open an issue to get aResolution-No ActivityIssue has had no activity for 6 months or more

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions