-
Notifications
You must be signed in to change notification settings - Fork 319
Alternate: Fix IndexOutOfRangeException in GenerateRender #1050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Insure that the next token on the token stack is checked for being the final token so that in the rare event that the EOS token is missing, rendering doesn't attempt to access non-existant tokens. Optimization of redundant evaluation in the subject `while` loop. Optimization of check for last token in current state. Fixes PowerShell#911
Test for Render Exception on missing EOS token when a nested token is also present.
aa98f7d to
7e06fa7
Compare
|
I like your changes better. I will update mine to be the same as yours with additional comments and one more test to cover the |
|
Interestingly, the |
|
@msftrncs Yes :) |
|
I almost submitted #989 with a the |
|
No worries at all. I didn't realize the |
|
Also, I invited you as a contributor to the PSReadLine repo, would you like to accept it? 😄 |
Offering slightly different, but really the same, fix for #911, along with a test, but with less explanation.
/cc: @daxian-dbw