Skip to content

Add syntax highlighting for 'clean {}' block #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andyleejordan merged 1 commit into from
Oct 14, 2021
Merged

Add syntax highlighting for 'clean {}' block #208

andyleejordan merged 1 commit into from
Oct 14, 2021

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Jul 16, 2021 •
edited
Loading

This is a follow-up PR of #186, because of the renaming of the new named block.

function Get-Foo {
    [CmdletBinding()]
    param()

    begin { }
    process { }
    end { }
    clean { }
}

Reference PowerShell/PowerShell#15177 for indication on when the feature will become available.
PowerShell/PowerShell#15177 did some design changes based on the original PR PowerShell/PowerShell#9900

/cc @andschwa and @vexx32

@andyleejordan
Copy link
Member

andyleejordan commented Jul 20, 2021

Thanks for this @daxian-dbw! We'll get it merged closer to the timeline of the feature itself being merged.

@daxian-dbw daxian-dbw mentioned this pull request Oct 14, 2021
Merged
15 tasks
@daxian-dbw
Copy link
Member Author

daxian-dbw commented Oct 14, 2021

@andschwa PowerShell/PowerShell#15177 has been merged, so can you please review this PR and maybe merge it as well?

andyleejordan
andyleejordan approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heck yeah! I see no reason not to merge this now.

@andyleejordan andyleejordan merged commit 742f0b5 into PowerShell:master Oct 14, 2021
@andyleejordan andyleejordan mentioned this pull request Oct 14, 2021
Closed
@daxian-dbw daxian-dbw deleted the block-name branch October 14, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andyleejordan andyleejordan andyleejordan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daxian-dbw @andyleejordan