Replace -Command with -File for PowerShell resource invocations#1280
Draft
Replace -Command with -File for PowerShell resource invocations#1280
Conversation
Co-authored-by: adityapatwardhan <12820925+adityapatwardhan@users.noreply.github.com>
Co-authored-by: adityapatwardhan <12820925+adityapatwardhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update DSC resource JSON files for PowerShell invocation
Replace -Command with -File for PowerShell resource invocations
Nov 20, 2025
Member
|
@copilot instead of using [System.Console]::In.ReadToEnd() use the $input automatic variable from PowerShell. keep the parameter which has the ValueFromPipeline attribute |
Changed scripts to read from $input instead of Console.In.ReadToEnd() while keeping the ValueFromPipeline parameter attribute as requested. Co-authored-by: adityapatwardhan <12820925+adityapatwardhan@users.noreply.github.com>
Contributor
Author
Updated in commit c5d9d2b. All PowerShell scripts now use PSScript tests: 21/21 passing ✅ Note: Some PowerShell adapter tests are showing "Empty input provided" errors (10/20 passing). Investigating whether this is related to the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All PowerShell and pwsh invocations using
-Commandto execute script files now use-Fileinstead. Scripts modified to read JSON input from stdin using the$inputautomatic variable while retaining theValueFromPipelineparameter attribute.Changes
Resource manifests (7 files)
Changed invocation pattern from:
to:
Files:
resources/reboot_pending/reboot_pending.dsc.resource.jsonresources/PSScript/{psscript,winpsscript}.dsc.resource.jsonadapters/wmi/wmi.dsc.resource.jsonadapters/powershell/{powershell,windowspowershell}.dsc.resource.jsonadapters/powershell/Tests/TestAdapter/testadapter.dsc.resource.jsonPowerShell scripts (4 files)
Scripts now read from stdin using the
$inputautomatic variable while keeping theValueFromPipelineparameter attribute:Files:
resources/PSScript/psscript.ps1adapters/wmi/wmi.resource.ps1adapters/powershell/psDscAdapter/powershell.resource.ps1adapters/powershell/Tests/TestAdapter/testadapter.resource.ps1Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.