Skip to content

dnsdist: Keep concurrent connection entries for live connections#17385

Open
rgacogne wants to merge 4 commits into
PowerDNS:masterfrom
rgacogne:ddist-keep-live-concurrent-connections
Open

dnsdist: Keep concurrent connection entries for live connections#17385
rgacogne wants to merge 4 commits into
PowerDNS:masterfrom
rgacogne:ddist-keep-live-concurrent-connections

Conversation

@rgacogne
Copy link
Copy Markdown
Member

Short description

Otherwise clients that manage to keep their connections around for a long time can bypass the limit.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

rgacogne added 3 commits May 15, 2026 16:51
Otherwise clients that manage to keep their connections around for
a long time can bypass the limit.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
@coveralls
Copy link
Copy Markdown

coveralls commented May 15, 2026

Coverage Report for CI Build 25925686369

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+4.1%) to 71.063%

Details

  • Coverage increased (+4.1%) from the base build.
  • Patch coverage: 29 of 29 lines across 2 files are fully covered (100%).
  • 269 coverage regressions across 17 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

269 previously-covered lines in 17 files lost coverage.

Top 10 Files by Coverage Loss Lines Losing Coverage Coverage
pdns/lua-record.cc 159 0.17%
pdns/snmp-agent.cc 32 63.16%
pdns/dnsdistdist/dnsdist-snmp.cc 28 55.29%
pdns/recursordist/rec-system-resolve.cc 19 49.32%
pdns/auth-secondarycommunicator.cc 4 59.58%
pdns/packethandler.cc 4 69.19%
pdns/dnsdistdist/dnsdist-healthchecks.cc 3 54.55%
pdns/logging.cc 3 80.23%
pdns/rcpgenerator.cc 3 89.77%
pdns/recursordist/test-syncres_cc2.cc 3 79.35%

Coverage Stats

Coverage Status
Relevant Lines: 170119
Covered Lines: 132395
Line Coverage: 77.82%
Relevant Branches: 81100
Covered Branches: 46129
Branch Coverage: 56.88%
Branches in Coverage %: Yes
Coverage Strength: 7128913.02 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants